Removed benchmark tests for ios from staging to move to prod.
Change-Id: Ia081e254e64592c6ce995a9c291c78881f15e6a6
Reviewed-on: https://flutter-review.googlesource.com/c/infra/+/32801
Reviewed-by: Yusuf Mohsinally <mohsinally@google.com>
Reviewed-by: Keyong Han <keyonghan@google.com>
Commit-Queue: Ricardo Amador <ricardoamador@google.com>
diff --git a/config/devicelab_staging_config.star b/config/devicelab_staging_config.star
index 68e5b01..3858a2d 100644
--- a/config/devicelab_staging_config.star
+++ b/config/devicelab_staging_config.star
@@ -23,13 +23,6 @@
DEFAULT_BRANCH = "master"
-# Staging tasks that should upload metrics.
-BENCHMARKS = [
- "flutter_gallery__transition_perf_e2e_ios",
- "flutter_gallery_ios__transition_perf",
- "flutter_gallery_ios_sksl_warmup__transition_perf",
-]
-
# Linux staging tasks that run on Samsung devices.
SAMSUNGTASKS = [
"imagefiltered_transform_animation_perf__timeline_summary",
@@ -154,14 +147,6 @@
use_bbagent = True,
)
- benchmark_notifies = [
- luci.notifier(
- name = "benchmark_notification",
- on_occurrence = ["INFRA_FAILURE", "FAILURE"],
- notify_emails = ["flutter-engine@grotations.appspotmail.com"],
- ),
- ]
-
# Defines console views.
console_view_name = "devicelab_staging"
luci.console_view(
@@ -205,11 +190,8 @@
"complex_layout_scroll_perf_ios__timeline_summary",
"external_ui_integration_test_ios",
"flavors_test_ios",
- "flutter_gallery__transition_perf_e2e_ios",
"flutter_gallery_ios__compile",
"flutter_gallery_ios__start_up",
- "flutter_gallery_ios__transition_perf",
- "flutter_gallery_ios_sksl_warmup__transition_perf",
"flutter_view_ios__start_up",
"hello_world_ios__compile",
"hot_mode_dev_cycle_macos_target__benchmark",
@@ -238,14 +220,14 @@
"tiles_scroll_perf_ios__timeline_summary",
]
for task in mac_ios_tasks:
- staging_suffix = "" if task in BENCHMARKS else "_staging"
+ staging_suffix = "_staging"
common.mac_prod_builder(
name = "Mac_ios%s %s|%s" % (staging_suffix, task, common.short_name(task)),
recipe = drone_recipe_name,
- console_view_name = benchmark_console_view_name if task in BENCHMARKS else console_view_name,
+ console_view_name = console_view_name,
triggered_by = [trigger_name],
triggering_policy = triggering_policy,
- notifies = benchmark_notifies if task in BENCHMARKS else None,
+ notifies = None,
properties = {
"$flutter/devicelab_osx_sdk": {
"sdk_version": XCODE_VERSION,
@@ -265,7 +247,7 @@
"task_name": task,
"git_branch": DEFAULT_BRANCH,
"use_cas": True,
- "upload_metrics": True if task in BENCHMARKS else False,
+ "upload_metrics": False,
},
bucket = "staging",
pool = "luci.flutter.staging",
@@ -442,10 +424,10 @@
common.linux_prod_builder(
name = "Linux_android%s %s|%s" % (staging_suffix, task, common.short_name(task)),
recipe = drone_recipe_name,
- console_view_name = benchmark_console_view_name if task in BENCHMARKS else console_view_name,
+ console_view_name = console_view_name,
triggered_by = [trigger_name],
triggering_policy = triggering_policy,
- notifies = benchmark_notifies if task in BENCHMARKS else None,
+ notifies = None,
properties = {
"dependencies": [
{
@@ -467,7 +449,7 @@
"task_name": task,
"git_branch": DEFAULT_BRANCH,
"use_cas": True,
- "upload_metrics": True if (task in BENCHMARKS or task in SAMSUNGTASKS) else False,
+ "upload_metrics": True if (task in SAMSUNGTASKS) else False,
},
category = "Linux_android",
bucket = "staging",
diff --git a/config/generated/flutter/luci/cr-buildbucket.cfg b/config/generated/flutter/luci/cr-buildbucket.cfg
index 1584483..a3b757d 100644
--- a/config/generated/flutter/luci/cr-buildbucket.cfg
+++ b/config/generated/flutter/luci/cr-buildbucket.cfg
@@ -171959,93 +171959,6 @@
}
}
builders {
- name: "Mac_ios flutter_gallery__transition_perf_e2e_ios"
- swarming_host: "chromium-swarm.appspot.com"
- dimensions: "cpu:x86"
- dimensions: "device_os:iOS-15"
- dimensions: "os:Mac-12"
- dimensions: "pool:luci.flutter.staging"
- exe {
- cipd_package: "flutter/recipe_bundles/flutter.googlesource.com/recipes"
- cipd_version: "refs/heads/main"
- cmd: "luciexe"
- }
- properties:
- '{'
- ' "$flutter/devicelab_osx_sdk": {'
- ' "sdk_version": "13f17a"'
- ' },'
- ' "$fuchsia/goma": {'
- ' "server": "rbe-prod1.endpoints.fuchsia-infra-goma-prod.cloud.goog"'
- ' },'
- ' "$kitchen": {'
- ' "emulate_gce": true'
- ' },'
- ' "$recipe_engine/isolated": {'
- ' "server": "https://isolateserver.appspot.com"'
- ' },'
- ' "$recipe_engine/swarming": {'
- ' "server": "https://chromium-swarm.appspot.com"'
- ' },'
- ' "clobber": false,'
- ' "dependencies": ['
- ' {'
- ' "dependency": "xcode"'
- ' },'
- ' {'
- ' "dependency": "gems"'
- ' },'
- ' {'
- ' "dependency": "apple_signing"'
- ' }'
- ' ],'
- ' "git_branch": "master",'
- ' "gold_tryjob": false,'
- ' "goma_jobs": "200",'
- ' "mastername": "client.flutter",'
- ' "recipe": "devicelab/devicelab_drone",'
- ' "tags": ['
- ' "devicelab",'
- ' "ios",'
- ' "mac",'
- ' "intel"'
- ' ],'
- ' "task_name": "flutter_gallery__transition_perf_e2e_ios",'
- ' "upload_metrics": true,'
- ' "upload_packages": true,'
- ' "use_cas": true'
- '}'
- execution_timeout_secs: 5400
- expiration_secs: 43200
- caches {
- name: "builder_mac_devicelab_staging"
- path: "builder"
- }
- caches {
- name: "flutter_sdk"
- path: "flutter sdk"
- }
- caches {
- name: "osx_sdk"
- path: "osx_sdk"
- }
- caches {
- name: "pub_cache"
- path: ".pub-cache"
- }
- caches {
- name: "xcode_binary"
- path: "xcode_binary"
- }
- build_numbers: YES
- service_account: "flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com"
- task_template_canary_percentage {}
- experiments {
- key: "luci.recipes.use_python3"
- value: 100
- }
- }
- builders {
name: "Mac_ios flutter_gallery_ios__compile"
swarming_host: "chromium-swarm.appspot.com"
dimensions: "cpu:x86"
@@ -172246,180 +172159,6 @@
}
}
builders {
- name: "Mac_ios flutter_gallery_ios__transition_perf"
- swarming_host: "chromium-swarm.appspot.com"
- dimensions: "cpu:x86"
- dimensions: "device_os:iOS-15"
- dimensions: "os:Mac-12"
- dimensions: "pool:luci.flutter.staging"
- exe {
- cipd_package: "flutter/recipe_bundles/flutter.googlesource.com/recipes"
- cipd_version: "refs/heads/main"
- cmd: "luciexe"
- }
- properties:
- '{'
- ' "$flutter/devicelab_osx_sdk": {'
- ' "sdk_version": "13f17a"'
- ' },'
- ' "$fuchsia/goma": {'
- ' "server": "rbe-prod1.endpoints.fuchsia-infra-goma-prod.cloud.goog"'
- ' },'
- ' "$kitchen": {'
- ' "emulate_gce": true'
- ' },'
- ' "$recipe_engine/isolated": {'
- ' "server": "https://isolateserver.appspot.com"'
- ' },'
- ' "$recipe_engine/swarming": {'
- ' "server": "https://chromium-swarm.appspot.com"'
- ' },'
- ' "clobber": false,'
- ' "dependencies": ['
- ' {'
- ' "dependency": "xcode"'
- ' },'
- ' {'
- ' "dependency": "gems"'
- ' },'
- ' {'
- ' "dependency": "apple_signing"'
- ' }'
- ' ],'
- ' "git_branch": "master",'
- ' "gold_tryjob": false,'
- ' "goma_jobs": "200",'
- ' "mastername": "client.flutter",'
- ' "recipe": "devicelab/devicelab_drone",'
- ' "tags": ['
- ' "devicelab",'
- ' "ios",'
- ' "mac",'
- ' "intel"'
- ' ],'
- ' "task_name": "flutter_gallery_ios__transition_perf",'
- ' "upload_metrics": true,'
- ' "upload_packages": true,'
- ' "use_cas": true'
- '}'
- execution_timeout_secs: 5400
- expiration_secs: 43200
- caches {
- name: "builder_mac_devicelab_staging"
- path: "builder"
- }
- caches {
- name: "flutter_sdk"
- path: "flutter sdk"
- }
- caches {
- name: "osx_sdk"
- path: "osx_sdk"
- }
- caches {
- name: "pub_cache"
- path: ".pub-cache"
- }
- caches {
- name: "xcode_binary"
- path: "xcode_binary"
- }
- build_numbers: YES
- service_account: "flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com"
- task_template_canary_percentage {}
- experiments {
- key: "luci.recipes.use_python3"
- value: 100
- }
- }
- builders {
- name: "Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf"
- swarming_host: "chromium-swarm.appspot.com"
- dimensions: "cpu:x86"
- dimensions: "device_os:iOS-15"
- dimensions: "os:Mac-12"
- dimensions: "pool:luci.flutter.staging"
- exe {
- cipd_package: "flutter/recipe_bundles/flutter.googlesource.com/recipes"
- cipd_version: "refs/heads/main"
- cmd: "luciexe"
- }
- properties:
- '{'
- ' "$flutter/devicelab_osx_sdk": {'
- ' "sdk_version": "13f17a"'
- ' },'
- ' "$fuchsia/goma": {'
- ' "server": "rbe-prod1.endpoints.fuchsia-infra-goma-prod.cloud.goog"'
- ' },'
- ' "$kitchen": {'
- ' "emulate_gce": true'
- ' },'
- ' "$recipe_engine/isolated": {'
- ' "server": "https://isolateserver.appspot.com"'
- ' },'
- ' "$recipe_engine/swarming": {'
- ' "server": "https://chromium-swarm.appspot.com"'
- ' },'
- ' "clobber": false,'
- ' "dependencies": ['
- ' {'
- ' "dependency": "xcode"'
- ' },'
- ' {'
- ' "dependency": "gems"'
- ' },'
- ' {'
- ' "dependency": "apple_signing"'
- ' }'
- ' ],'
- ' "git_branch": "master",'
- ' "gold_tryjob": false,'
- ' "goma_jobs": "200",'
- ' "mastername": "client.flutter",'
- ' "recipe": "devicelab/devicelab_drone",'
- ' "tags": ['
- ' "devicelab",'
- ' "ios",'
- ' "mac",'
- ' "intel"'
- ' ],'
- ' "task_name": "flutter_gallery_ios_sksl_warmup__transition_perf",'
- ' "upload_metrics": true,'
- ' "upload_packages": true,'
- ' "use_cas": true'
- '}'
- execution_timeout_secs: 5400
- expiration_secs: 43200
- caches {
- name: "builder_mac_devicelab_staging"
- path: "builder"
- }
- caches {
- name: "flutter_sdk"
- path: "flutter sdk"
- }
- caches {
- name: "osx_sdk"
- path: "osx_sdk"
- }
- caches {
- name: "pub_cache"
- path: ".pub-cache"
- }
- caches {
- name: "xcode_binary"
- path: "xcode_binary"
- }
- build_numbers: YES
- service_account: "flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com"
- task_template_canary_percentage {}
- experiments {
- key: "luci.recipes.use_python3"
- value: 100
- }
- }
- builders {
name: "Mac_ios flutter_view_ios__start_up"
swarming_host: "chromium-swarm.appspot.com"
dimensions: "cpu:x86"
diff --git a/config/generated/flutter/luci/luci-milo.cfg b/config/generated/flutter/luci/luci-milo.cfg
index 26d901e..8364a43 100644
--- a/config/generated/flutter/luci/luci-milo.cfg
+++ b/config/generated/flutter/luci/luci-milo.cfg
@@ -433,21 +433,6 @@
repo_url: "https://flutter.googlesource.com/mirrors/flutter"
refs: "regexp:refs/heads/master"
manifest_name: "REVISION"
- builders {
- name: "buildbucket/luci.flutter.staging/Mac_ios flutter_gallery__transition_perf_e2e_ios"
- category: "Mac_ios"
- short_name: "fgtpe"
- }
- builders {
- name: "buildbucket/luci.flutter.staging/Mac_ios flutter_gallery_ios__transition_perf"
- category: "Mac_ios"
- short_name: "fgitp"
- }
- builders {
- name: "buildbucket/luci.flutter.staging/Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf"
- category: "Mac_ios"
- short_name: "fgisw"
- }
favicon_url: "https://storage.googleapis.com/flutter_infra/favicon.ico"
}
consoles {
diff --git a/config/generated/flutter/luci/luci-notify.cfg b/config/generated/flutter/luci/luci-notify.cfg
index 68f0c57..aab7cc2 100644
--- a/config/generated/flutter/luci/luci-notify.cfg
+++ b/config/generated/flutter/luci/luci-notify.cfg
@@ -1088,48 +1088,6 @@
notifications {
on_occurrence: INFRA_FAILURE
on_occurrence: FAILURE
- email {
- recipients: "flutter-engine@grotations.appspotmail.com"
- }
- }
- builders {
- bucket: "staging"
- name: "Mac_ios flutter_gallery__transition_perf_e2e_ios"
- repository: "https://flutter.googlesource.com/mirrors/flutter"
- }
-}
-notifiers {
- notifications {
- on_occurrence: INFRA_FAILURE
- on_occurrence: FAILURE
- email {
- recipients: "flutter-engine@grotations.appspotmail.com"
- }
- }
- builders {
- bucket: "staging"
- name: "Mac_ios flutter_gallery_ios__transition_perf"
- repository: "https://flutter.googlesource.com/mirrors/flutter"
- }
-}
-notifiers {
- notifications {
- on_occurrence: INFRA_FAILURE
- on_occurrence: FAILURE
- email {
- recipients: "flutter-engine@grotations.appspotmail.com"
- }
- }
- builders {
- bucket: "staging"
- name: "Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf"
- repository: "https://flutter.googlesource.com/mirrors/flutter"
- }
-}
-notifiers {
- notifications {
- on_occurrence: INFRA_FAILURE
- on_occurrence: FAILURE
failed_step_regexp: "(^build|.*test:|.*step is flaky).*"
email {
recipients: "flutter-engine@grotations.appspotmail.com"
diff --git a/config/generated/flutter/luci/luci-scheduler.cfg b/config/generated/flutter/luci/luci-scheduler.cfg
index 1b30eac..b7854f3 100644
--- a/config/generated/flutter/luci/luci-scheduler.cfg
+++ b/config/generated/flutter/luci/luci-scheduler.cfg
@@ -5761,48 +5761,6 @@
}
}
job {
- id: "Mac_ios flutter_gallery__transition_perf_e2e_ios"
- realm: "staging"
- triggering_policy {
- kind: GREEDY_BATCHING
- max_concurrent_invocations: 1
- max_batch_size: 20
- }
- buildbucket {
- server: "cr-buildbucket.appspot.com"
- bucket: "staging"
- builder: "Mac_ios flutter_gallery__transition_perf_e2e_ios"
- }
-}
-job {
- id: "Mac_ios flutter_gallery_ios__transition_perf"
- realm: "staging"
- triggering_policy {
- kind: GREEDY_BATCHING
- max_concurrent_invocations: 1
- max_batch_size: 20
- }
- buildbucket {
- server: "cr-buildbucket.appspot.com"
- bucket: "staging"
- builder: "Mac_ios flutter_gallery_ios__transition_perf"
- }
-}
-job {
- id: "Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf"
- realm: "staging"
- triggering_policy {
- kind: GREEDY_BATCHING
- max_concurrent_invocations: 1
- max_batch_size: 20
- }
- buildbucket {
- server: "cr-buildbucket.appspot.com"
- bucket: "staging"
- builder: "Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf"
- }
-}
-job {
id: "Mac_ios stable animation_with_microtasks_perf_ios__timeline_summary"
realm: "prod"
triggering_policy {
@@ -8430,9 +8388,6 @@
triggers: "Mac_arm64_android_staging integration_test_test"
triggers: "Mac_arm64_android_staging run_release_test"
triggers: "Mac_arm64_staging ios_app_with_extensions_test"
- triggers: "Mac_ios flutter_gallery__transition_perf_e2e_ios"
- triggers: "Mac_ios flutter_gallery_ios__transition_perf"
- triggers: "Mac_ios flutter_gallery_ios_sksl_warmup__transition_perf"
triggers: "Mac_ios_staging animation_with_microtasks_perf_ios__timeline_summary"
triggers: "Mac_ios_staging backdrop_filter_perf_ios__timeline_summary"
triggers: "Mac_ios_staging basic_material_app_ios__compile"
