Change RetryOptions for getCiYaml call (#2453)
* Adjust the timeout for the second call to the get ci.yaml file.
* Add delay factor to all calls.
* Make 4 attempts so we wait at least 20 seconds to get the file.
* Remove old TODO note.
diff --git a/app_dart/lib/src/service/scheduler.dart b/app_dart/lib/src/service/scheduler.dart
index c9b0080..cd7f379 100644
--- a/app_dart/lib/src/service/scheduler.dart
+++ b/app_dart/lib/src/service/scheduler.dart
@@ -213,7 +213,7 @@
Future<CiYaml> getCiYaml(
Commit commit, {
CiYaml? totCiYaml,
- RetryOptions retryOptions = const RetryOptions(maxAttempts: 3),
+ RetryOptions retryOptions = const RetryOptions(delayFactor: Duration(seconds: 2), maxAttempts: 4),
}) async {
String ciPath;
ciPath = '${commit.repository}/${commit.sha!}/$kCiYamlPath';
@@ -406,9 +406,14 @@
late CiYaml ciYaml;
log.info('Attempting to read presubmit targets from ci.yaml for ${pullRequest.number}');
if (commit.branch == Config.defaultBranch(commit.slug)) {
+ // This fails when we attempt the second call to getCiYaml since the retry
+ // options did not set a high enough delay factor.
final Commit totCommit = await generateTotCommit(slug: commit.slug, branch: Config.defaultBranch(commit.slug));
final CiYaml totYaml = await getCiYaml(totCommit);
- ciYaml = await getCiYaml(commit, totCiYaml: totYaml);
+ ciYaml = await getCiYaml(
+ commit,
+ totCiYaml: totYaml,
+ );
} else {
ciYaml = await getCiYaml(commit);
}
