commit 93d42dacafed8e83b7802be5c483de1fb6e89704
author Jenn Magder <magder@google.com> Tue Nov 08 11:41:08 2022 -0800
committer GitHub <noreply@github.com> Tue Nov 08 19:41:08 2022 +0000
tree caf0a91238cacc4749f536e12b3804b85554175a
parent 3474feaf2afcdde96a7eaaa9ee7fc2fd8f09fe59

Add shell scripts to engine test pattern (#2294)

* Add shell scripts to engine test pattern

* Format

app_dart/lib/src/request_handlers/github/webhook_subscription.dart

diff --git a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
index ed8c7ae..fcfa650 100644
--- a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
+++ b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart
@@ -32,7 +32,7 @@
   'flutter/plugins',
 };
 
-final RegExp kEngineTestRegExp = RegExp(r'(tests?|benchmarks?)\.(dart|java|mm|m|cc)$');
+final RegExp kEngineTestRegExp = RegExp(r'(tests?|benchmarks?)\.(dart|java|mm|m|cc|sh)$');
 final List<String> kNeedsTestsLabels = <String>['needs tests'];
 
 /// Subscription for processing GitHub webhooks.

app_dart/test/request_handlers/github/webhook_subscription_test.dart

diff --git a/app_dart/test/request_handlers/github/webhook_subscription_test.dart b/app_dart/test/request_handlers/github/webhook_subscription_test.dart
index 636bdb8..7dba6b4 100644
--- a/app_dart/test/request_handlers/github/webhook_subscription_test.dart
+++ b/app_dart/test/request_handlers/github/webhook_subscription_test.dart
@@ -1759,6 +1759,33 @@
       );
     });
 
+    test('Engine labels PRs, no comment if script tests', () async {
+      const int issueNumber = 123;
+
+      tester.message = generateGithubWebhookMessage(
+        action: 'opened',
+        number: issueNumber,
+        slug: Config.engineSlug,
+      );
+
+      when(pullRequestsService.listFiles(Config.engineSlug, issueNumber)).thenAnswer(
+        (_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
+          PullRequestFile()..filename = 'fml/blah.cc',
+          PullRequestFile()..filename = 'fml/testing/blah_test.sh',
+        ]),
+      );
+
+      await tester.post(webhook);
+
+      verifyNever(
+        issuesService.createComment(
+          Config.engineSlug,
+          issueNumber,
+          argThat(contains(config.missingTestsPullRequestMessageValue)),
+        ),
+      );
+    });
+
     test('Engine labels PRs, no comment if cc tests', () async {
       const int issueNumber = 123;
 
@@ -1794,7 +1821,7 @@
       );
     });
 
-    test('Engine labels PRs, no comment if cc becnhmarks', () async {
+    test('Engine labels PRs, no comment if cc benchmarks', () async {
       const int issueNumber = 123;
 
       tester.message = generateGithubWebhookMessage(