commit dec394e5401b62024ed71253e900c25a06eb46f9
author Ricardo Amador <32242716+ricardoamador@users.noreply.github.com> Wed Oct 05 10:30:16 2022 -0700
committer GitHub <noreply@github.com> Wed Oct 05 17:30:16 2022 +0000
tree 3af9c6ceb3761497a18c222d10db47a0dccd21ea
parent fbe142d2cb60fb981521cfe72961642d69db8784

Quarantined device debugging (#2187)

device_doctor/lib/src/ios_device.dart

diff --git a/device_doctor/lib/src/ios_device.dart b/device_doctor/lib/src/ios_device.dart
index 98a35af..58b2301 100644
--- a/device_doctor/lib/src/ios_device.dart
+++ b/device_doctor/lib/src/ios_device.dart
@@ -41,13 +41,17 @@
 
   @override
   Future<List<Device>> discoverDevices({Duration retryDuration = const Duration(seconds: 10)}) async {
-    return LineSplitter.split(await deviceListOutput()).map((String id) => IosDevice(deviceId: id)).toList();
+    final List<Device> discoveredDevices =
+        LineSplitter.split(await deviceListOutput()).map((String id) => IosDevice(deviceId: id)).toList();
+    stdout.write("ios devices discovered: ${discoveredDevices.map((e) => e.deviceId).toList()}");
+    return discoveredDevices;
   }
 
   Future<String> deviceListOutput({
     ProcessManager processManager = const LocalProcessManager(),
   }) async {
     final String fullPathIdeviceId = await getMacBinaryPath('idevice_id', processManager: processManager);
+    stdout.write("idevice_id path $fullPathIdeviceId");
     return eval(fullPathIdeviceId, <String>['-l'], processManager: processManager);
   }
 
@@ -206,6 +210,7 @@
     processManager ??= LocalProcessManager();
     try {
       if (noRebootList.contains(deviceId)) {
+        stdout.write("Device not marked for reboot.");
         return true;
       }
       final String fullPathIdevicediagnostics =
@@ -215,12 +220,13 @@
       stderr.write('device restart fails: $error');
       return false;
     }
+    stdout.write("Restart device complete.");
     return true;
   }
 
   /// Uninstall applications from a device.
   ///
-  /// This is to prevent application installation failure caused by using different siging
+  /// This is to prevent application installation failure caused by using different signing
   /// certificate from previous installed application.
   /// Issue: https://github.com/flutter/flutter/issues/76896
   @visibleForTesting
@@ -237,6 +243,7 @@
 
     // Skip uninstalling process when no device is available or no application exists.
     if (result == 'No device found.' || result == 'CFBundleIdentifier, CFBundleVersion, CFBundleDisplayName') {
+      stdout.write("No device was found or no application to uninstall exists.");
       return true;
     }
     final List<String> results = result.trim().split('\n');
@@ -249,6 +256,7 @@
       stderr.write('uninstall applications fails: $error');
       return false;
     }
+    stdout.write("Uninstall complete.");
     return true;
   }
 }