Ensure all golden filenames end in .png. (#40604)
Ensure all golden filenames end in .png.
diff --git a/lib/web_ui/test/canvaskit/font_variation_golden_test.dart b/lib/web_ui/test/canvaskit/font_variation_golden_test.dart
index 5f582f0..3b85682 100644
--- a/lib/web_ui/test/canvaskit/font_variation_golden_test.dart
+++ b/lib/web_ui/test/canvaskit/font_variation_golden_test.dart
@@ -56,7 +56,7 @@
canvas.drawParagraph(paragraph, const ui.Offset(10, 10));
final CkPicture picture = recorder.endRecording();
await matchPictureGolden(
- 'font_variation.jpg',
+ 'font_variation.png',
picture,
region: ui.Rect.fromLTRB(0, 0, testWidth, paragraph.height + 20),
);
diff --git a/lib/web_ui/test/canvaskit/image_golden_test.dart b/lib/web_ui/test/canvaskit/image_golden_test.dart
index 6940776..6a9dfde 100644
--- a/lib/web_ui/test/canvaskit/image_golden_test.dart
+++ b/lib/web_ui/test/canvaskit/image_golden_test.dart
@@ -779,7 +779,7 @@
}
CanvasKitRenderer.instance.rasterizer.draw(sb.build().layerTree);
await matchGoldenFile(
- 'canvaskit_picture_texture_toimage',
+ 'canvaskit_picture_texture_toimage.png',
region: const ui.Rect.fromLTRB(0, 0, 128, 128),
);
mandrill.dispose();
diff --git a/web_sdk/web_engine_tester/lib/golden_tester.dart b/web_sdk/web_engine_tester/lib/golden_tester.dart
index f27b657..904a7eb 100644
--- a/web_sdk/web_engine_tester/lib/golden_tester.dart
+++ b/web_sdk/web_engine_tester/lib/golden_tester.dart
@@ -49,6 +49,9 @@
/// [pixelComparison] determines the algorithm used to compare pixels. Uses
/// fuzzy comparison by default.
Future<void> matchGoldenFile(String filename, {Rect? region}) async {
+ if (!filename.endsWith('.png')) {
+ throw ArgumentError('Filename must end in .png or SkiaGold will ignore it.');
+ }
final Map<String, dynamic> serverParams = <String, dynamic>{
'filename': filename,
'region': region == null
