commit c4e79d7eb95bdcac275b4d6a89a34ba971b47fa2
author Jason Simmons <jason-simmons@users.noreply.github.com> Tue Jan 05 18:15:18 2021 -0800
committer GitHub <noreply@github.com> Tue Jan 05 18:15:18 2021 -0800
tree dce9b42aebfde01dc6fc0d1b5ac5d4580eecdb52
parent e115066dcd65008513c66414f2f682c358d76c2a

Update the web profiler_test to wrap benchmark callbacks with allowInterop (#23439)

This is now required by js_util.setProperty
(see https://github.com/dart-lang/sdk/commit/d683f33f5bfefe92ea1a590a800c7e41b213f69c)

lib/web_ui/test/engine/profiler_test.dart

diff --git a/lib/web_ui/test/engine/profiler_test.dart b/lib/web_ui/test/engine/profiler_test.dart
index 49f1124..c2fb54e 100644
--- a/lib/web_ui/test/engine/profiler_test.dart
+++ b/lib/web_ui/test/engine/profiler_test.dart
@@ -4,6 +4,7 @@
 
 // @dart = 2.6
 import 'dart:html' as html;
+import 'dart:js' as js;
 import 'dart:js_util' as js_util;
 
 import 'package:test/bootstrap/browser.dart';
@@ -60,14 +61,13 @@
     });
     expect(
       () => Profiler.instance.benchmark('foo', 123),
-      throwsA(isA<TypeError>()),
+      throwsA(isA<NoSuchMethodError>()),
     );
     expect(data, isEmpty);
 
     // Not even a callback.
-    jsOnBenchmark('string');
     expect(
-      () => Profiler.instance.benchmark('foo', 123),
+      () => jsOnBenchmark('string'),
       throwsA(isA<TypeError>()),
     );
   });
@@ -102,5 +102,5 @@
 }
 
 void jsOnBenchmark(dynamic listener) {
-  js_util.setProperty(html.window, '_flutter_internal_on_benchmark', listener);
+  js_util.setProperty(html.window, '_flutter_internal_on_benchmark', listener != null ? js.allowInterop(listener) : null);
 }