commit cd65368f9dec3bbc98992225978a4b7f164322f7
author Rulong Chen（陈汝龙） <rulong.crl@alibaba-inc.com> Fri Jan 21 06:00:11 2022 +0800
committer GitHub <noreply@github.com> Thu Jan 20 14:00:11 2022 -0800
tree 2202f93c5098cbe16811bd99c75655aaeff31511
parent 0cc48929aff6d4442bb789a4cfb978db544b44b5

Check weak pointer to avoid potential use-after-free crash (#30396)

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

diff --git a/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm b/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
index 708d3fa..5e45a02 100644
--- a/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
+++ b/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
@@ -518,15 +518,17 @@
     FML_DCHECK(RasterTaskRunner->RunsTasksOnCurrentThread());
     // Get callback on raster thread and jump back to platform thread.
     platformTaskRunner->PostTask([weakSelf]() {
-      fml::scoped_nsobject<FlutterViewController> flutterViewController(
-          [(FlutterViewController*)weakSelf.get() retain]);
-      if (flutterViewController) {
-        if (flutterViewController.get()->_splashScreenView) {
-          [flutterViewController removeSplashScreenView:^{
+      if (weakSelf) {
+        fml::scoped_nsobject<FlutterViewController> flutterViewController(
+            [(FlutterViewController*)weakSelf.get() retain]);
+        if (flutterViewController) {
+          if (flutterViewController.get()->_splashScreenView) {
+            [flutterViewController removeSplashScreenView:^{
+              [flutterViewController callViewRenderedCallback];
+            }];
+          } else {
             [flutterViewController callViewRenderedCallback];
-          }];
-        } else {
-          [flutterViewController callViewRenderedCallback];
+          }
         }
       }
     });