Remove ignores that are not ignoring anything (#25128)
diff --git a/lib/web_ui/dev/chrome.dart b/lib/web_ui/dev/chrome.dart
index 9ae072b..728df7b 100644
--- a/lib/web_ui/dev/chrome.dart
+++ b/lib/web_ui/dev/chrome.dart
@@ -9,7 +9,7 @@
import 'package:pedantic/pedantic.dart';
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
+import 'package:test_core/src/util/io.dart';
import 'browser.dart';
import 'chrome_installer.dart';
diff --git a/lib/web_ui/dev/firefox.dart b/lib/web_ui/dev/firefox.dart
index b0f1558..ccff178 100644
--- a/lib/web_ui/dev/firefox.dart
+++ b/lib/web_ui/dev/firefox.dart
@@ -9,7 +9,7 @@
import 'package:pedantic/pedantic.dart';
import 'package:path/path.dart' as path;
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
+import 'package:test_core/src/util/io.dart';
import 'browser.dart';
import 'common.dart';
diff --git a/lib/web_ui/dev/test_platform.dart b/lib/web_ui/dev/test_platform.dart
index 8e181ea..5373add 100644
--- a/lib/web_ui/dev/test_platform.dart
+++ b/lib/web_ui/dev/test_platform.dart
@@ -25,18 +25,18 @@
import 'package:web_test_utils/goldens.dart';
import 'package:web_test_utils/image_compare.dart';
-import 'package:test_api/src/backend/runtime.dart'; // ignore: implementation_imports
-import 'package:test_api/src/backend/suite_platform.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/runner_suite.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/platform.dart'; // ignore: implementation_imports
-import 'package:test_core/src/util/stack_trace_mapper.dart'; // ignore: implementation_imports
-import 'package:test_api/src/utils.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/suite.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/plugin/platform_helpers.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/environment.dart'; // ignore: implementation_imports
+import 'package:test_api/src/backend/runtime.dart';
+import 'package:test_api/src/backend/suite_platform.dart';
+import 'package:test_core/src/runner/runner_suite.dart';
+import 'package:test_core/src/runner/platform.dart';
+import 'package:test_core/src/util/stack_trace_mapper.dart';
+import 'package:test_api/src/utils.dart';
+import 'package:test_core/src/runner/suite.dart';
+import 'package:test_core/src/runner/plugin/platform_helpers.dart';
+import 'package:test_core/src/runner/environment.dart';
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/configuration.dart'; // ignore: implementation_imports
+import 'package:test_core/src/util/io.dart';
+import 'package:test_core/src/runner/configuration.dart';
import 'browser.dart';
import 'common.dart';
diff --git a/lib/web_ui/dev/test_runner.dart b/lib/web_ui/dev/test_runner.dart
index e82dfdb..85280f2 100644
--- a/lib/web_ui/dev/test_runner.dart
+++ b/lib/web_ui/dev/test_runner.dart
@@ -11,10 +11,10 @@
import 'package:path/path.dart' as path;
import 'package:pool/pool.dart';
import 'package:test_core/src/runner/hack_register_platform.dart'
- as hack; // ignore: implementation_imports
-import 'package:test_api/src/backend/runtime.dart'; // ignore: implementation_imports
+ as hack;
+import 'package:test_api/src/backend/runtime.dart';
import 'package:test_core/src/executable.dart'
- as test; // ignore: implementation_imports
+ as test;
import 'package:web_test_utils/goldens.dart';
import 'common.dart';
diff --git a/lib/web_ui/lib/src/engine.dart b/lib/web_ui/lib/src/engine.dart
index 8855692..9e2537f 100644
--- a/lib/web_ui/lib/src/engine.dart
+++ b/lib/web_ui/lib/src/engine.dart
@@ -17,8 +17,8 @@
import 'dart:math' as math;
import 'dart:typed_data';
-import 'package:js/js.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:meta/meta.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:js/js.dart';
+import 'package:meta/meta.dart';
import '../ui.dart' as ui;
diff --git a/lib/web_ui/lib/src/engine/bitmap_canvas.dart b/lib/web_ui/lib/src/engine/bitmap_canvas.dart
index 628bddd..a9fbd63 100644
--- a/lib/web_ui/lib/src/engine/bitmap_canvas.dart
+++ b/lib/web_ui/lib/src/engine/bitmap_canvas.dart
@@ -577,7 +577,7 @@
String cssColor = paint.color == null
? '#000000'
: colorToCssString(
- paint.color)!; // ignore: unnecessary_null_comparison
+ paint.color)!;
final double sigma = paint.maskFilter!.webOnlySigma;
if (browserEngine == BrowserEngine.webkit && !isStroke) {
// A bug in webkit leaves artifacts when this element is animated
diff --git a/lib/web_ui/lib/src/engine/window.dart b/lib/web_ui/lib/src/engine/window.dart
index c6e0ea6..fe8b6b7 100644
--- a/lib/web_ui/lib/src/engine/window.dart
+++ b/lib/web_ui/lib/src/engine/window.dart
@@ -272,7 +272,6 @@
//
// TODO: Add integration test https://github.com/flutter/flutter/issues/66852
@JS('_flutter_web_set_location_strategy')
-// ignore: unused_element
external set _jsSetUrlStrategy(_JsSetUrlStrategy? newJsSetUrlStrategy);
UrlStrategy? _createDefaultUrlStrategy() {
diff --git a/lib/web_ui/test/color_test.dart b/lib/web_ui/test/color_test.dart
index d48ea0b..9718c26 100644
--- a/lib/web_ui/test/color_test.dart
+++ b/lib/web_ui/test/color_test.dart
@@ -55,7 +55,7 @@
test('two colors are only == if they have the same runtime type', () {
expect(const Color(123), equals(const Color(123)));
expect(const Color(123),
- equals(Color(123))); // ignore: prefer_const_constructors
+ equals(Color(123)));
expect(const Color(123), isNot(equals(const Color(321))));
expect(const Color(123), isNot(equals(const NotAColor(123))));
expect(const NotAColor(123), isNot(equals(const Color(123))));
diff --git a/lib/web_ui/test/engine/path_metrics_test.dart b/lib/web_ui/test/engine/path_metrics_test.dart
index a709120..a8938f9 100644
--- a/lib/web_ui/test/engine/path_metrics_test.dart
+++ b/lib/web_ui/test/engine/path_metrics_test.dart
@@ -4,11 +4,11 @@
import 'dart:math' as math;
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:ui/ui.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
+import 'package:ui/ui.dart';
-import '../matchers.dart'; // ignore: import_of_legacy_library_into_null_safe
+import '../matchers.dart';
const double kTolerance = 0.001;
diff --git a/lib/web_ui/test/engine/surface/path/path_iterator_test.dart b/lib/web_ui/test/engine/surface/path/path_iterator_test.dart
index f0c9143..3e4c21e 100644
--- a/lib/web_ui/test/engine/surface/path/path_iterator_test.dart
+++ b/lib/web_ui/test/engine/surface/path/path_iterator_test.dart
@@ -5,8 +5,8 @@
import 'dart:typed_data';
import 'package:ui/src/engine.dart';
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
void main() {
internalBootstrapBrowserTest(() => testMain);
diff --git a/lib/web_ui/test/engine/surface/path/path_winding_test.dart b/lib/web_ui/test/engine/surface/path/path_winding_test.dart
index 941da71..f74a112 100644
--- a/lib/web_ui/test/engine/surface/path/path_winding_test.dart
+++ b/lib/web_ui/test/engine/surface/path/path_winding_test.dart
@@ -5,8 +5,8 @@
// @dart = 2.12
import 'dart:math' as math;
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
import 'package:ui/ui.dart' hide window;
import 'package:ui/src/engine.dart';
diff --git a/lib/web_ui/test/engine/ulps_test.dart b/lib/web_ui/test/engine/ulps_test.dart
index 871efcd..d0a26c4 100644
--- a/lib/web_ui/test/engine/ulps_test.dart
+++ b/lib/web_ui/test/engine/ulps_test.dart
@@ -3,8 +3,8 @@
// found in the LICENSE file.
import 'dart:typed_data';
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
import 'package:ui/src/engine.dart';
void main() {
diff --git a/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart b/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart
index 1e6f66e..17ab3e2 100644
--- a/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart
+++ b/lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart
@@ -6,12 +6,12 @@
import 'dart:html' as html;
import 'dart:js_util' as js_util;
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
import 'package:ui/ui.dart';
import 'package:ui/src/engine.dart' hide PhysicalShapeEngineLayer;
-import 'package:web_engine_tester/golden_tester.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:web_engine_tester/golden_tester.dart';
final Rect region = Rect.fromLTWH(0, 0, 500, 500);
diff --git a/lib/web_ui/test/lerp_test.dart b/lib/web_ui/test/lerp_test.dart
index 1d458d3..026b42e 100644
--- a/lib/web_ui/test/lerp_test.dart
+++ b/lib/web_ui/test/lerp_test.dart
@@ -3,8 +3,8 @@
// found in the LICENSE file.
// @dart = 2.12
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
import 'package:ui/ui.dart';
diff --git a/lib/web_ui/test/path_test.dart b/lib/web_ui/test/path_test.dart
index da3d773..cc1eb2c 100644
--- a/lib/web_ui/test/path_test.dart
+++ b/lib/web_ui/test/path_test.dart
@@ -7,12 +7,12 @@
import 'dart:js_util' as js_util;
import 'dart:html' as html;
import 'dart:typed_data';
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
import 'package:ui/ui.dart' hide window;
import 'package:ui/src/engine.dart';
-import 'matchers.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'matchers.dart';
void main() {
internalBootstrapBrowserTest(() => testMain);
diff --git a/lib/web_ui/test/text/line_breaker_test.dart b/lib/web_ui/test/text/line_breaker_test.dart
index 6f8a417..4fe5968 100644
--- a/lib/web_ui/test/text/line_breaker_test.dart
+++ b/lib/web_ui/test/text/line_breaker_test.dart
@@ -3,8 +3,8 @@
// found in the LICENSE file.
// @dart = 2.12
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
import 'package:ui/src/engine.dart';
import 'package:ui/ui.dart';
