commit 2a6e1002eba6819f54301b7a0e96833fc2a51b47
author Kaushik Iska <iska.kaushik@gmail.com> Mon Oct 17 11:33:51 2022 -0500
committer GitHub <noreply@github.com> Mon Oct 17 16:33:51 2022 +0000
tree 9a5e0da36dd9c34ca0f6c867fc8319e8d71b1ad7
parent 25f423681d3d153a8c2cfaa1d397fba0f722a3e8

[Impeller] Do not terminate on performance related validation failures (#36776)

impeller/renderer/backend/vulkan/context_vk.cc

diff --git a/impeller/renderer/backend/vulkan/context_vk.cc b/impeller/renderer/backend/vulkan/context_vk.cc
index 3e071eb..7d6850a 100644
--- a/impeller/renderer/backend/vulkan/context_vk.cc
+++ b/impeller/renderer/backend/vulkan/context_vk.cc
@@ -347,9 +347,16 @@
            VkDebugUtilsMessageTypeFlagsEXT type,
            const VkDebugUtilsMessengerCallbackDataEXT* data,
            void* user_data) -> VkBool32 {
-      FML_DCHECK(false)
-          << vk::to_string(vk::DebugUtilsMessageSeverityFlagBitsEXT{severity})
-          << ": " << data->pMessage;
+      if (type == VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT) {
+        // do not terminate on performance warnings.
+        FML_LOG(ERROR)
+            << vk::to_string(vk::DebugUtilsMessageSeverityFlagBitsEXT{severity})
+            << ": " << data->pMessage;
+      } else {
+        FML_DCHECK(false)
+            << vk::to_string(vk::DebugUtilsMessageSeverityFlagBitsEXT{severity})
+            << ": " << data->pMessage;
+      }
       return true;
     };