Flip the default for proguard (#40282)
diff --git a/packages/flutter_tools/lib/src/commands/build_apk.dart b/packages/flutter_tools/lib/src/commands/build_apk.dart index 6ed6b41..a27d9f4 100644 --- a/packages/flutter_tools/lib/src/commands/build_apk.dart +++ b/packages/flutter_tools/lib/src/commands/build_apk.dart
@@ -30,7 +30,7 @@ ) ..addFlag('proguard', negatable: true, - defaultsTo: true, + defaultsTo: false, help: 'Whether to enable Proguard on release mode. ' 'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard', )
diff --git a/packages/flutter_tools/lib/src/commands/build_appbundle.dart b/packages/flutter_tools/lib/src/commands/build_appbundle.dart index 48f9eeb..1a53b52 100644 --- a/packages/flutter_tools/lib/src/commands/build_appbundle.dart +++ b/packages/flutter_tools/lib/src/commands/build_appbundle.dart
@@ -24,7 +24,7 @@ ..addFlag('track-widget-creation', negatable: false, hide: !verboseHelp) ..addFlag('proguard', negatable: true, - defaultsTo: true, + defaultsTo: false, help: 'Whether to enable Proguard on release mode. ' 'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard', )
diff --git a/packages/flutter_tools/test/general.shard/commands/build_apk_test.dart b/packages/flutter_tools/test/general.shard/commands/build_apk_test.dart index 68b9bc2..f3d19b8 100644 --- a/packages/flutter_tools/test/general.shard/commands/build_apk_test.dart +++ b/packages/flutter_tools/test/general.shard/commands/build_apk_test.dart
@@ -165,6 +165,7 @@ GradleUtils: () => GradleUtils(), ProcessManager: () => mockProcessManager, }, + skip: true, timeout: allowForCreateFlutterProject); testUsingContext('proguard is disabled when --no-proguard is passed', () async { @@ -197,6 +198,7 @@ GradleUtils: () => GradleUtils(), ProcessManager: () => mockProcessManager, }, + skip: true, timeout: allowForCreateFlutterProject); testUsingContext('guides the user when proguard fails', () async { @@ -255,6 +257,7 @@ ProcessManager: () => mockProcessManager, Usage: () => mockUsage, }, + skip: true, timeout: allowForCreateFlutterProject); }); }
diff --git a/packages/flutter_tools/test/general.shard/commands/build_appbundle_test.dart b/packages/flutter_tools/test/general.shard/commands/build_appbundle_test.dart index 7a0f02a..4548e3c 100644 --- a/packages/flutter_tools/test/general.shard/commands/build_appbundle_test.dart +++ b/packages/flutter_tools/test/general.shard/commands/build_appbundle_test.dart
@@ -152,6 +152,7 @@ GradleUtils: () => GradleUtils(), ProcessManager: () => mockProcessManager, }, + skip: true, timeout: allowForCreateFlutterProject); testUsingContext('proguard is disabled when --no-proguard is passed', () async { @@ -186,6 +187,7 @@ GradleUtils: () => GradleUtils(), ProcessManager: () => mockProcessManager, }, + skip: true, timeout: allowForCreateFlutterProject); testUsingContext('guides the user when proguard fails', () async { @@ -244,6 +246,7 @@ ProcessManager: () => mockProcessManager, Usage: () => mockUsage, }, + skip: true, timeout: allowForCreateFlutterProject); }); }