🥅 Produce warning instead of error for storage base url overrides (#119595)
* 🥅 Only log warning for storage base url
* ✅ Add test
* ✅ Add the link to the test
* ✅ Remove the test
* ✅ Remove the extra import
diff --git a/packages/flutter_tools/lib/src/cache.dart b/packages/flutter_tools/lib/src/cache.dart
index 17a2838..356618e 100644
--- a/packages/flutter_tools/lib/src/cache.dart
+++ b/packages/flutter_tools/lib/src/cache.dart
@@ -520,7 +520,7 @@
if (_hasWarnedAboutStorageOverride) {
return;
}
- _logger.printError(
+ _logger.printWarning(
'Flutter assets will be downloaded from $overrideUrl. Make sure you trust this source!',
emphasis: true,
);
diff --git a/packages/flutter_tools/test/general.shard/cache_test.dart b/packages/flutter_tools/test/general.shard/cache_test.dart
index 04b0e85..c6628f1 100644
--- a/packages/flutter_tools/test/general.shard/cache_test.dart
+++ b/packages/flutter_tools/test/general.shard/cache_test.dart
@@ -319,7 +319,7 @@
expect(() => cache.storageBaseUrl, throwsToolExit());
});
- testWithoutContext('overridden storage base url prints warning to STDERR', () async {
+ testWithoutContext('overridden storage base url prints warning', () async {
final BufferLogger logger = BufferLogger.test();
const String baseUrl = 'https://storage.com';
final Cache cache = Cache.test(
@@ -331,7 +331,7 @@
);
expect(cache.storageBaseUrl, baseUrl);
- expect(logger.errorText, contains('Flutter assets will be downloaded from $baseUrl'));
+ expect(logger.warningText, contains('Flutter assets will be downloaded from $baseUrl'));
expect(logger.statusText, isEmpty);
});
});
