Send text selection rects to engine on iPhone (#113048)
diff --git a/packages/flutter/lib/src/widgets/editable_text.dart b/packages/flutter/lib/src/widgets/editable_text.dart
index babed8a..745bf8e 100644
--- a/packages/flutter/lib/src/widgets/editable_text.dart
+++ b/packages/flutter/lib/src/widgets/editable_text.dart
@@ -63,10 +63,6 @@
// is shown in an obscured text field.
const int _kObscureShowLatestCharCursorTicks = 3;
-// The minimum width of an iPad screen. The smallest iPad is currently the
-// iPad Mini 6th Gen according to ios-resolution.com.
-const double _kIPadWidth = 1488.0;
-
/// A controller for an editable text field.
///
/// Whenever the user modifies a text field with an associated
@@ -3144,10 +3140,6 @@
if (defaultTargetPlatform != TargetPlatform.iOS) {
return;
}
- // This is to avoid sending selection rects on non-iPad devices.
- if (WidgetsBinding.instance.window.physicalSize.shortestSide < _kIPadWidth) {
- return;
- }
final String text = renderEditable.text?.toPlainText(includeSemanticsLabels: false) ?? '';
final List<Rect> firstSelectionBoxes = renderEditable.getBoxesForSelection(const TextSelection(baseOffset: 0, extentOffset: 1));
diff --git a/packages/flutter/test/widgets/editable_text_test.dart b/packages/flutter/test/widgets/editable_text_test.dart
index ff0f237..f96d9a7 100644
--- a/packages/flutter/test/widgets/editable_text_test.dart
+++ b/packages/flutter/test/widgets/editable_text_test.dart
@@ -4624,6 +4624,10 @@
});
testWidgets('selection rects are sent when they change', (WidgetTester tester) async {
+ addTearDown(tester.binding.window.clearPhysicalSizeTestValue);
+ // Ensure selection rects are sent on iPhone (using SE 3rd gen size)
+ tester.binding.window.physicalSizeTestValue = const Size(750.0, 1334.0);
+
final List<MethodCall> log = <MethodCall>[];
SystemChannels.textInput.setMockMethodCallHandler((MethodCall methodCall) async {
log.add(methodCall);
