dev: Use a super-parameter in several missed cases (#182251)
Work towards https://github.com/dart-lang/sdk/issues/58729
The lint rule will suggest using a super-parameter for a named parameter
even if the positional parameters cannot be super-parameters.
I'm not sure why unrelated lines were formatted.
diff --git a/dev/devicelab/lib/tasks/new_gallery.dart b/dev/devicelab/lib/tasks/new_gallery.dart
index 9e5e458..a5331ea 100644
--- a/dev/devicelab/lib/tasks/new_gallery.dart
+++ b/dev/devicelab/lib/tasks/new_gallery.dart
@@ -8,7 +8,7 @@
class NewGalleryPerfTest extends PerfTest {
NewGalleryPerfTest({
String timelineFileName = 'transitions',
- String dartDefine = '',
+ super.dartDefine = '',
super.enableImpeller,
super.timeoutSeconds,
super.forceOpenGLES,
@@ -16,7 +16,6 @@
'${flutterDirectory.path}/dev/integration_tests/new_gallery',
'test_driver/transitions_perf.dart',
timelineFileName,
- dartDefine: dartDefine,
createPlatforms: <String>['android', 'ios', 'web'],
enableMergedPlatformThread: true,
);
diff --git a/dev/integration_tests/android_views/lib/motion_events_page.dart b/dev/integration_tests/android_views/lib/motion_events_page.dart
index 907c2cc..b81d987 100644
--- a/dev/integration_tests/android_views/lib/motion_events_page.dart
+++ b/dev/integration_tests/android_views/lib/motion_events_page.dart
@@ -18,8 +18,8 @@
const String kEventsFileName = 'touchEvents';
class MotionEventsPage extends PageWidget {
- const MotionEventsPage({Key? key})
- : super('Motion Event Tests', const ValueKey<String>('MotionEventsListTile'), key: key);
+ const MotionEventsPage({super.key})
+ : super('Motion Event Tests', const ValueKey<String>('MotionEventsListTile'));
@override
Widget build(BuildContext context) {
diff --git a/dev/integration_tests/android_views/lib/wm_integrations.dart b/dev/integration_tests/android_views/lib/wm_integrations.dart
index 5b3fc72..af66e1e 100644
--- a/dev/integration_tests/android_views/lib/wm_integrations.dart
+++ b/dev/integration_tests/android_views/lib/wm_integrations.dart
@@ -10,12 +10,8 @@
import 'page.dart';
class WindowManagerIntegrationsPage extends PageWidget {
- const WindowManagerIntegrationsPage({Key? key})
- : super(
- 'Window Manager Integrations Tests',
- const ValueKey<String>('WmIntegrationsListTile'),
- key: key,
- );
+ const WindowManagerIntegrationsPage({super.key})
+ : super('Window Manager Integrations Tests', const ValueKey<String>('WmIntegrationsListTile'));
@override
Widget build(BuildContext context) => const WindowManagerBody();
diff --git a/dev/integration_tests/flutter_gallery/lib/demo/calculator/home.dart b/dev/integration_tests/flutter_gallery/lib/demo/calculator/home.dart
index 4af9d21..140583e 100644
--- a/dev/integration_tests/flutter_gallery/lib/demo/calculator/home.dart
+++ b/dev/integration_tests/flutter_gallery/lib/demo/calculator/home.dart
@@ -248,8 +248,8 @@
}
class NumberKey extends CalcKey {
- NumberKey(int value, CalculatorState? calcState, {Key? key})
+ NumberKey(int value, CalculatorState? calcState, {super.key})
: super('$value', () {
calcState!.handleNumberTap(value);
- }, key: key);
+ });
}
diff --git a/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart b/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart
index e60c567..9b4d8b9 100644
--- a/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart
+++ b/dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart
@@ -17,8 +17,8 @@
const String kEventsFileName = 'touchEvents';
class MotionEventsPage extends PageWidget {
- const MotionEventsPage({Key? key})
- : super('Motion Event Tests', const ValueKey<String>('MotionEventsListTile'), key: key);
+ const MotionEventsPage({super.key})
+ : super('Motion Event Tests', const ValueKey<String>('MotionEventsListTile'));
@override
Widget build(BuildContext context) {
diff --git a/dev/integration_tests/hybrid_android_views/lib/nested_view_event_page.dart b/dev/integration_tests/hybrid_android_views/lib/nested_view_event_page.dart
index 87ee840..e1c99f7 100644
--- a/dev/integration_tests/hybrid_android_views/lib/nested_view_event_page.dart
+++ b/dev/integration_tests/hybrid_android_views/lib/nested_view_event_page.dart
@@ -12,8 +12,8 @@
import 'page.dart';
class NestedViewEventPage extends PageWidget {
- const NestedViewEventPage({Key? key})
- : super('Nested View Event Tests', const ValueKey<String>('NestedViewEventTile'), key: key);
+ const NestedViewEventPage({super.key})
+ : super('Nested View Event Tests', const ValueKey<String>('NestedViewEventTile'));
@override
Widget build(BuildContext context) => const NestedViewEventBody();
diff --git a/dev/snippets/lib/src/data_types.dart b/dev/snippets/lib/src/data_types.dart
index ed32204..e858c10 100644
--- a/dev/snippets/lib/src/data_types.dart
+++ b/dev/snippets/lib/src/data_types.dart
@@ -157,9 +157,9 @@
/// Snippets are code that is not meant to be run as a complete application, but
/// rather as a code usage example.
class SnippetSample extends CodeSample {
- SnippetSample(List<SourceLine> input, {required int index, required SourceLine lineProto})
+ SnippetSample(List<SourceLine> input, {required super.index, required super.lineProto})
: assumptions = <SourceLine>[],
- super(<String>['snippet'], input, index: index, lineProto: lineProto);
+ super(<String>['snippet'], input);
factory SnippetSample.combine(
List<SnippetSample> sections, {