Switch over to the new name for compilation trace native function (#25594) * Switch over to the new name for compilation trace native function. Also see: https://github.com/flutter/engine/pull/7256 * rename * roll the engine
diff --git a/bin/internal/engine.version b/bin/internal/engine.version index 93345ad..7d405fd 100644 --- a/bin/internal/engine.version +++ b/bin/internal/engine.version
@@ -1 +1 @@ -dbdb5e6f8c9fc8add75d7b5a19bdaa1144a9332e +e859296b71def257f021ff8bd225e82209558cea
diff --git a/packages/flutter/lib/src/foundation/binding.dart b/packages/flutter/lib/src/foundation/binding.dart index eb6ac0c..d2e677c 100644 --- a/packages/flutter/lib/src/foundation/binding.dart +++ b/packages/flutter/lib/src/foundation/binding.dart
@@ -6,7 +6,7 @@ import 'dart:convert' show json; import 'dart:developer' as developer; import 'dart:io' show exit; -import 'dart:ui' show dumpCompilationTrace; +import 'dart:ui' show saveCompilationTrace; import 'package:meta/meta.dart'; @@ -119,10 +119,10 @@ callback: _exitApplication, ); registerServiceExtension( - name: 'dumpCompilationTrace', + name: 'saveCompilationTrace', callback: (Map<String, String> parameters) async { return <String, dynamic> { - 'value': dumpCompilationTrace(), + 'value': saveCompilationTrace(), }; } );
diff --git a/packages/flutter/test/foundation/service_extensions_test.dart b/packages/flutter/test/foundation/service_extensions_test.dart index 286856f..8cea1e2 100644 --- a/packages/flutter/test/foundation/service_extensions_test.dart +++ b/packages/flutter/test/foundation/service_extensions_test.dart
@@ -527,9 +527,9 @@ expect(binding.frameScheduled, isFalse); }); - test('Service extensions - dumpCompilationTrace', () async { + test('Service extensions - saveCompilationTrace', () async { Map<String, dynamic> result; - result = await binding.testExtension('dumpCompilationTrace', <String, String>{}); + result = await binding.testExtension('saveCompilationTrace', <String, String>{}); final String trace = String.fromCharCodes(result['value']); expect(trace, contains('dart:core,Object,Object.\n')); expect(trace, contains('package:test_api/test_api.dart,::,test\n'));
diff --git a/packages/flutter_tools/lib/src/resident_runner.dart b/packages/flutter_tools/lib/src/resident_runner.dart index 5b3edf2..f18f145 100644 --- a/packages/flutter_tools/lib/src/resident_runner.dart +++ b/packages/flutter_tools/lib/src/resident_runner.dart
@@ -490,7 +490,7 @@ Future<void> stop() async { _stopped = true; if (saveCompilationTrace) - await _saveCompilationTrace(); + await _debugSaveCompilationTrace(); await stopEchoingDeviceLog(); await preStop(); return stopApp(); @@ -595,7 +595,7 @@ } } - Future<void> _saveCompilationTrace() async { + Future<void> _debugSaveCompilationTrace() async { if (!supportsServiceProtocol) return; @@ -607,7 +607,7 @@ List<int> buffer; try { - buffer = await view.uiIsolate.flutterDumpCompilationTrace(); + buffer = await view.uiIsolate.flutterDebugSaveCompilationTrace(); assert(buffer != null); } catch (error) { printError('Error communicating with Flutter on the device: $error');
diff --git a/packages/flutter_tools/lib/src/vmservice.dart b/packages/flutter_tools/lib/src/vmservice.dart index a14f27e..83f837a 100644 --- a/packages/flutter_tools/lib/src/vmservice.dart +++ b/packages/flutter_tools/lib/src/vmservice.dart
@@ -1312,9 +1312,9 @@ ); } - Future<List<int>> flutterDumpCompilationTrace() async { + Future<List<int>> flutterDebugSaveCompilationTrace() async { final Map<String, dynamic> result = - await invokeFlutterExtensionRpcRaw('ext.flutter.dumpCompilationTrace'); + await invokeFlutterExtensionRpcRaw('ext.flutter.saveCompilationTrace'); if (result != null && result['value'] is List<dynamic>) return result['value'].cast<int>(); return null;