ImageProvider.toString uses double.toStringAsFixed (#131348)
This provides consistency for web vs VM (and is more consistent with how we do doubles everywhere else in toStrings).
diff --git a/packages/flutter/lib/src/painting/_network_image_io.dart b/packages/flutter/lib/src/painting/_network_image_io.dart
index 8105227..05dd8cb 100644
--- a/packages/flutter/lib/src/painting/_network_image_io.dart
+++ b/packages/flutter/lib/src/painting/_network_image_io.dart
@@ -185,5 +185,5 @@
int get hashCode => Object.hash(url, scale);
@override
- String toString() => '${objectRuntimeType(this, 'NetworkImage')}("$url", scale: $scale)';
+ String toString() => '${objectRuntimeType(this, 'NetworkImage')}("$url", scale: ${scale.toStringAsFixed(1)})';
}
diff --git a/packages/flutter/lib/src/painting/_network_image_web.dart b/packages/flutter/lib/src/painting/_network_image_web.dart
index ceb012e..95e97e0 100644
--- a/packages/flutter/lib/src/painting/_network_image_web.dart
+++ b/packages/flutter/lib/src/painting/_network_image_web.dart
@@ -215,6 +215,5 @@
int get hashCode => Object.hash(url, scale);
@override
- String toString() =>
- '${objectRuntimeType(this, 'NetworkImage')}("$url", scale: $scale)';
+ String toString() => '${objectRuntimeType(this, 'NetworkImage')}("$url", scale: ${scale.toStringAsFixed(1)})';
}
diff --git a/packages/flutter/lib/src/painting/image_provider.dart b/packages/flutter/lib/src/painting/image_provider.dart
index 57aabc1..728ccbf 100644
--- a/packages/flutter/lib/src/painting/image_provider.dart
+++ b/packages/flutter/lib/src/painting/image_provider.dart
@@ -1618,7 +1618,7 @@
int get hashCode => Object.hash(file.path, scale);
@override
- String toString() => '${objectRuntimeType(this, 'FileImage')}("${file.path}", scale: $scale)';
+ String toString() => '${objectRuntimeType(this, 'FileImage')}("${file.path}", scale: ${scale.toStringAsFixed(1)})';
}
/// Decodes the given [Uint8List] buffer as an image, associating it with the
@@ -1722,7 +1722,7 @@
int get hashCode => Object.hash(bytes.hashCode, scale);
@override
- String toString() => '${objectRuntimeType(this, 'MemoryImage')}(${describeIdentity(bytes)}, scale: $scale)';
+ String toString() => '${objectRuntimeType(this, 'MemoryImage')}(${describeIdentity(bytes)}, scale: ${scale.toStringAsFixed(1)})';
}
/// Fetches an image from an [AssetBundle], associating it with the given scale.
@@ -1863,7 +1863,7 @@
int get hashCode => Object.hash(keyName, scale, bundle);
@override
- String toString() => '${objectRuntimeType(this, 'ExactAssetImage')}(name: "$keyName", scale: $scale, bundle: $bundle)';
+ String toString() => '${objectRuntimeType(this, 'ExactAssetImage')}(name: "$keyName", scale: ${scale.toStringAsFixed(1)}, bundle: $bundle)';
}
// A completer used when resolving an image fails sync.
diff --git a/packages/flutter/test/painting/image_provider_test.dart b/packages/flutter/test/painting/image_provider_test.dart
index 05d3030..737471d 100644
--- a/packages/flutter/test/painting/image_provider_test.dart
+++ b/packages/flutter/test/painting/image_provider_test.dart
@@ -159,6 +159,12 @@
expect(imageCache.statusForKey(provider).untracked, false);
expect(imageCache.pendingImageCount, 1);
}, skip: kIsWeb); // [intended] The web cannot load files.
+
+ test('ImageProvider toStrings', () async {
+ expect(const NetworkImage('test', scale: 1.21).toString(), 'NetworkImage("test", scale: 1.2)');
+ expect(const ExactAssetImage('test', scale: 1.21).toString(), 'ExactAssetImage(name: "test", scale: 1.2, bundle: null)');
+ expect(MemoryImage(Uint8List(0), scale: 1.21).toString(), equalsIgnoringHashCodes('MemoryImage(Uint8List#00000, scale: 1.2)'));
+ });
}
class FakeCodec implements Codec {
