blob: 4a4006398ab29b5142a845eea3115ad951765f22 [file] [log] [blame]
Dan Field8af3e482019-01-11 13:38:02 -08001# Specify analysis options.
2#
3# Until there are meta linter rules, each desired lint must be explicitly enabled.
4# See: https://github.com/dart-lang/linter/issues/288
5#
6# For a list of lints, see: http://dart-lang.github.io/linter/lints/
7# See the configuration guide for more
8# https://github.com/dart-lang/sdk/tree/master/pkg/analyzer#configuring-the-analyzer
9#
10# There are other similar analysis options files in the flutter repos,
11# which should be kept in sync with this file:
12#
13# - analysis_options.yaml (this file)
14# - packages/flutter/lib/analysis_options_user.yaml
15# - https://github.com/flutter/plugins/blob/master/analysis_options.yaml
16# - https://github.com/flutter/engine/blob/master/analysis_options.yaml
17#
18# This file contains the analysis options used by Flutter tools, such as IntelliJ,
19# Android Studio, and the `flutter analyze` command.
krisgiesing07b5f832016-05-04 10:15:15 -070020
21analyzer:
Dan Field8af3e482019-01-11 13:38:02 -080022 strong-mode:
Alexandre Ardhuin78db9652019-12-19 11:23:01 +010023 implicit-casts: false
Dan Field8af3e482019-01-11 13:38:02 -080024 implicit-dynamic: false
krisgiesing07b5f832016-05-04 10:15:15 -070025 errors:
Dan Field8af3e482019-01-11 13:38:02 -080026 # treat missing required parameters as a warning (not a hint)
27 missing_required_param: warning
28 # treat missing returns as a warning (not a hint)
29 missing_return: warning
30 # allow having TODOs in the code
31 todo: ignore
Christopher Fujino5cfb16b2020-06-19 12:03:38 -070032 # allow self-reference to deprecated members (we do this because otherwise we have
33 # to annotate every member in every test, assert, etc, when we deprecate something)
34 deprecated_member_use_from_same_package: ignore
Sivab1109222019-01-03 10:55:50 -080035 # Ignore analyzer hints for updating pubspecs when using Future or
36 # Stream and not importing dart:async
37 # Please see https://github.com/flutter/flutter/pull/24528 for details.
Alexander Aprelevfe1a51a2018-12-27 14:55:07 -080038 sdk_version_async_exported_from_core: ignore
Devon Carew207451f2016-08-18 19:11:39 -070039 exclude:
Alexandre Ardhuin919dcf52019-06-27 21:23:16 +020040 - "bin/cache/**"
Ian Hicksoncbda2082017-01-22 16:43:24 -080041 # the following two are relative to the stocks example and the flutter package respectively
42 # see https://github.com/dart-lang/sdk/issues/28463
Shi-Hao Hong3e4bf572019-11-06 12:52:03 -080043 - "lib/i18n/messages_*.dart"
Alexandre Ardhuin919dcf52019-06-27 21:23:16 +020044 - "lib/src/http/**"
Dan Field8af3e482019-01-11 13:38:02 -080045
46linter:
47 rules:
48 # these rules are documented on and in the same order as
49 # the Dart Lint rules page to make maintenance easier
50 # https://github.com/dart-lang/linter/blob/master/example/all.yaml
51 - always_declare_return_types
52 - always_put_control_body_on_new_line
53 # - always_put_required_named_parameters_first # we prefer having parameters in the same order as fields https://github.com/flutter/flutter/issues/10219
54 - always_require_non_null_named_parameters
55 - always_specify_types
Alexandre Ardhuin73301a32020-10-16 00:37:04 +020056 # - always_use_package_imports # we do this commonly
Dan Field8af3e482019-01-11 13:38:02 -080057 - annotate_overrides
58 # - avoid_annotating_with_dynamic # conflicts with always_specify_types
Alexandre Ardhuine6935ef2019-11-25 21:03:29 +010059 # - avoid_as # required for implicit-casts: true
Alexandre Ardhuinfecf99f2019-06-25 17:40:05 +020060 - avoid_bool_literals_in_conditional_expressions
Dan Field8af3e482019-01-11 13:38:02 -080061 # - avoid_catches_without_on_clauses # we do this commonly
62 # - avoid_catching_errors # we do this commonly
63 - avoid_classes_with_only_static_members
64 # - avoid_double_and_int_checks # only useful when targeting JS runtime
65 - avoid_empty_else
Alexandre Ardhuinf5a99022020-04-06 22:36:01 +020066 - avoid_equals_and_hash_code_on_mutable_classes
Alexandre Ardhuin73301a32020-10-16 00:37:04 +020067 # - avoid_escaping_inner_quotes # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -080068 - avoid_field_initializers_in_const_classes
69 - avoid_function_literals_in_foreach_calls
70 # - avoid_implementing_value_types # not yet tested
71 - avoid_init_to_null
72 # - avoid_js_rounded_ints # only useful when targeting JS runtime
73 - avoid_null_checks_in_equality_operators
74 # - avoid_positional_boolean_parameters # not yet tested
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +010075 # - avoid_print # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -080076 # - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
Alexandre Ardhuin0bd45bc2020-02-14 09:43:52 +010077 # - avoid_redundant_argument_values # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -080078 - avoid_relative_lib_imports
79 - avoid_renaming_method_parameters
80 - avoid_return_types_on_setters
81 # - avoid_returning_null # there are plenty of valid reasons to return null
82 # - avoid_returning_null_for_future # not yet tested
83 - avoid_returning_null_for_void
84 # - avoid_returning_this # there are plenty of valid reasons to return this
85 # - avoid_setters_without_getters # not yet tested
Ian Hickson6cff3382020-11-16 11:07:37 -080086 - avoid_shadowing_type_parameters
Alexandre Ardhuinc2ae6542020-03-05 08:03:26 +010087 - avoid_single_cascade_in_expression_statements
Dan Field8af3e482019-01-11 13:38:02 -080088 - avoid_slow_async_io
Alexandre Ardhuin73301a32020-10-16 00:37:04 +020089 # - avoid_type_to_string # we do this commonly
Dan Field8af3e482019-01-11 13:38:02 -080090 - avoid_types_as_parameter_names
91 # - avoid_types_on_closure_parameters # conflicts with always_specify_types
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +010092 # - avoid_unnecessary_containers # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -080093 - avoid_unused_constructor_parameters
94 - avoid_void_async
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +010095 # - avoid_web_libraries_in_flutter # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -080096 - await_only_futures
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +010097 - camel_case_extensions
Dan Field8af3e482019-01-11 13:38:02 -080098 - camel_case_types
99 - cancel_subscriptions
100 # - cascade_invocations # not yet tested
Alexandre Ardhuin4acc7902020-10-08 21:05:43 +0200101 - cast_nullable_to_non_nullable
Dan Field8af3e482019-01-11 13:38:02 -0800102 # - close_sinks # not reliable enough
103 # - comment_references # blocked on https://github.com/flutter/flutter/issues/20765
104 # - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
105 - control_flow_in_finally
Ian Hickson6cff3382020-11-16 11:07:37 -0800106 # - curly_braces_in_flow_control_structures # not required by flutter style
Alexandre Ardhuin9a3a7492019-06-25 15:59:15 +0200107 # - diagnostic_describe_all_properties # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800108 - directives_ordering
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200109 # - do_not_use_environment # we do this commonly
Dan Field8af3e482019-01-11 13:38:02 -0800110 - empty_catches
111 - empty_constructor_bodies
112 - empty_statements
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200113 - exhaustive_cases
Dan Field8af3e482019-01-11 13:38:02 -0800114 # - file_names # not yet tested
115 - flutter_style_todos
116 - hash_and_equals
117 - implementation_imports
118 # - invariant_booleans # too many false positives: https://github.com/dart-lang/linter/issues/811
119 - iterable_contains_unrelated_type
Ian Hickson6cff3382020-11-16 11:07:37 -0800120 # - join_return_with_assignment # not required by flutter style
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200121 - leading_newlines_in_multiline_strings
Dan Field8af3e482019-01-11 13:38:02 -0800122 - library_names
123 - library_prefixes
Ian Hickson6cff3382020-11-16 11:07:37 -0800124 # - lines_longer_than_80_chars # not required by flutter style
Dan Field8af3e482019-01-11 13:38:02 -0800125 - list_remove_unrelated_type
126 # - literal_only_boolean_expressions # too many false positives: https://github.com/dart-lang/sdk/issues/34181
Alexandre Ardhuin0bd45bc2020-02-14 09:43:52 +0100127 # - missing_whitespace_between_adjacent_strings # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800128 - no_adjacent_strings_in_list
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200129 # - no_default_cases # too many false positives
Dan Field8af3e482019-01-11 13:38:02 -0800130 - no_duplicate_case_values
Ian Hickson6cff3382020-11-16 11:07:37 -0800131 - no_logic_in_create_state
132 # - no_runtimeType_toString # ok in tests; we enable this only in packages/
Dan Field8af3e482019-01-11 13:38:02 -0800133 - non_constant_identifier_names
Alexandre Ardhuind2858f02020-10-08 09:39:13 +0200134 - null_check_on_nullable_type_parameter
Ian Hickson6cff3382020-11-16 11:07:37 -0800135 # - null_closures # not required by flutter style
Dan Field8af3e482019-01-11 13:38:02 -0800136 # - omit_local_variable_types # opposite of always_specify_types
137 # - one_member_abstracts # too many false positives
138 # - only_throw_errors # https://github.com/flutter/flutter/issues/5792
139 - overridden_fields
140 - package_api_docs
Phil Quitslund1fef5912020-09-23 21:37:08 -0700141 # - package_names # non conforming packages in sdk
Dan Field8af3e482019-01-11 13:38:02 -0800142 - package_prefixed_library_names
143 # - parameter_assignments # we do this commonly
144 - prefer_adjacent_string_concatenation
145 - prefer_asserts_in_initializer_lists
Ian Hickson6cff3382020-11-16 11:07:37 -0800146 # - prefer_asserts_with_message # not required by flutter style
Phil Quitslund802eca22019-03-06 11:05:16 -0800147 - prefer_collection_literals
Dan Field8af3e482019-01-11 13:38:02 -0800148 - prefer_conditional_assignment
Dan Fieldfe9512f2019-04-29 16:02:42 -0700149 - prefer_const_constructors
Dan Field8af3e482019-01-11 13:38:02 -0800150 - prefer_const_constructors_in_immutables
151 - prefer_const_declarations
152 - prefer_const_literals_to_create_immutables
Ian Hickson6cff3382020-11-16 11:07:37 -0800153 # - prefer_constructors_over_static_methods # far too many false positives
Dan Field8af3e482019-01-11 13:38:02 -0800154 - prefer_contains
Alexandre Ardhuin9a3a7492019-06-25 15:59:15 +0200155 # - prefer_double_quotes # opposite of prefer_single_quotes
Dan Field8af3e482019-01-11 13:38:02 -0800156 - prefer_equal_for_default_values
157 # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#consider-using--for-short-functions-and-methods
158 - prefer_final_fields
Alexandre Ardhuin4f9b6cf2020-01-07 16:32:04 +0100159 - prefer_final_in_for_each
Dan Field8af3e482019-01-11 13:38:02 -0800160 - prefer_final_locals
Alexandre Ardhuina5419342020-01-08 17:03:02 +0100161 - prefer_for_elements_to_map_fromIterable
Dan Field8af3e482019-01-11 13:38:02 -0800162 - prefer_foreach
163 # - prefer_function_declarations_over_variables # not yet tested
164 - prefer_generic_function_type_aliases
Alexandre Ardhuindf4bf452019-09-17 16:23:44 +0200165 - prefer_if_elements_to_conditional_expressions
Alexandre Ardhuinb041a582019-07-09 10:53:35 +0200166 - prefer_if_null_operators
Dan Field8af3e482019-01-11 13:38:02 -0800167 - prefer_initializing_formals
Alexandre Ardhuin919dcf52019-06-27 21:23:16 +0200168 - prefer_inlined_adds
Dan Field8af3e482019-01-11 13:38:02 -0800169 # - prefer_int_literals # not yet tested
170 # - prefer_interpolation_to_compose_strings # not yet tested
171 - prefer_is_empty
Alexandre Ardhuinc0125cb2019-05-20 17:00:45 +0200172 - prefer_is_not_empty
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +0100173 - prefer_is_not_operator
Dan Field8af3e482019-01-11 13:38:02 -0800174 - prefer_iterable_whereType
175 # - prefer_mixin # https://github.com/dart-lang/language/issues/32
Alexandre Ardhuinc0125cb2019-05-20 17:00:45 +0200176 # - prefer_null_aware_operators # disable until NNBD, see https://github.com/flutter/flutter/pull/32711#issuecomment-492930932
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +0100177 # - prefer_relative_imports # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800178 - prefer_single_quotes
Alexandre Ardhuin919dcf52019-06-27 21:23:16 +0200179 - prefer_spread_collections
Dan Field8af3e482019-01-11 13:38:02 -0800180 - prefer_typing_uninitialized_variables
181 - prefer_void_to_null
Alexandre Ardhuin9a3a7492019-06-25 15:59:15 +0200182 # - provide_deprecation_message # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800183 # - public_member_api_docs # enabled on a case-by-case basis; see e.g. packages/analysis_options.yaml
184 - recursive_getters
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200185 # - sized_box_for_whitespace # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800186 - slash_for_doc_comments
Alexandre Ardhuin9a3a7492019-06-25 15:59:15 +0200187 # - sort_child_properties_last # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800188 - sort_constructors_first
Phil Quitslund1fef5912020-09-23 21:37:08 -0700189 # - sort_pub_dependencies # prevents separating pinned transitive dependencies
Dan Field8af3e482019-01-11 13:38:02 -0800190 - sort_unnamed_constructors_first
Dan Field8af3e482019-01-11 13:38:02 -0800191 - test_types_in_equals
192 - throw_in_finally
Alexandre Ardhuind2858f02020-10-08 09:39:13 +0200193 - tighten_type_of_initializing_formals
Dan Field8af3e482019-01-11 13:38:02 -0800194 # - type_annotate_public_apis # subset of always_specify_types
195 - type_init_formals
196 # - unawaited_futures # too many false positives
197 # - unnecessary_await_in_return # not yet tested
198 - unnecessary_brace_in_string_interps
199 - unnecessary_const
Alexandre Ardhuin4adad2c2019-12-23 18:40:56 +0100200 # - unnecessary_final # conflicts with prefer_final_locals
Dan Field8af3e482019-01-11 13:38:02 -0800201 - unnecessary_getters_setters
202 # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498
203 - unnecessary_new
204 - unnecessary_null_aware_assignments
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200205 # - unnecessary_null_checks # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800206 - unnecessary_null_in_if_null_operators
Alexandre Ardhuin71c1f6c2020-09-23 06:39:47 +0200207 - unnecessary_nullable_for_final_variable_declarations
Dan Field8af3e482019-01-11 13:38:02 -0800208 - unnecessary_overrides
209 - unnecessary_parenthesis
Alexandre Ardhuin73301a32020-10-16 00:37:04 +0200210 # - unnecessary_raw_strings # not yet tested
Dan Field8af3e482019-01-11 13:38:02 -0800211 - unnecessary_statements
Alexandre Ardhuin17cdf552020-10-26 20:42:05 +0100212 - unnecessary_string_escapes
Alexandre Ardhuin0bd45bc2020-02-14 09:43:52 +0100213 - unnecessary_string_interpolations
Dan Field8af3e482019-01-11 13:38:02 -0800214 - unnecessary_this
215 - unrelated_type_equality_checks
Alexandre Ardhuin9a3a7492019-06-25 15:59:15 +0200216 # - unsafe_html # not yet tested
Alexandre Ardhuinb5ce0612019-06-25 17:58:19 +0200217 - use_full_hex_values_for_flutter_colors
Dan Field8af3e482019-01-11 13:38:02 -0800218 # - use_function_type_syntax_for_parameters # not yet tested
Alexandre Ardhuinc0176c92020-10-16 20:20:00 +0200219 - use_is_even_rather_than_modulo
Alexandre Ardhuin0bd45bc2020-02-14 09:43:52 +0100220 # - use_key_in_widget_constructors # not yet tested
Ian Hickson8a6a76a2020-08-27 16:38:10 -0700221 - use_late_for_private_fields_and_variables
Alexandre Ardhuin17cdf552020-10-26 20:42:05 +0100222 - use_raw_strings
Dan Field8af3e482019-01-11 13:38:02 -0800223 - use_rethrow_when_possible
224 # - use_setters_to_change_properties # not yet tested
225 # - use_string_buffers # has false positives: https://github.com/dart-lang/sdk/issues/34182
226 # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review
227 - valid_regexps
Ian Hicksone2b169e2020-01-13 10:03:01 -0800228 - void_checks