blob: 709766febdbc7efa9d4dd41e21226b1a0da97874 [file] [log] [blame] [view]
Michael Goderbauerf6036422019-02-20 15:41:28 -08001## Description
2
Michael Goderbauer0bc94f22019-02-20 18:40:33 -08003*Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).*
Michael Goderbauerf6036422019-02-20 15:41:28 -08004
5## Related Issues
6
Michael Goderbauer0bc94f22019-02-20 18:40:33 -08007*Replace this paragraph with a list of issues related to this PR from our [issue database]. Indicate, which of these issues are resolved or fixed by this PR.*
Michael Goderbauerf6036422019-02-20 15:41:28 -08008
Ian Hickson1123b712019-03-28 17:44:58 -07009## Tests
10
11I added the following tests:
12
13*Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
14will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See [Test Coverage].*
15
Michael Goderbauerf6036422019-02-20 15:41:28 -080016## Checklist
17
Michael Goderbauer0bc94f22019-02-20 18:40:33 -080018Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
Michael Goderbauerf6036422019-02-20 15:41:28 -080019
Michael Goderbauer0bc94f22019-02-20 18:40:33 -080020- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
Michael Goderbauerf6036422019-02-20 15:41:28 -080021- [ ] I signed the [CLA].
Ian Hickson1123b712019-03-28 17:44:58 -070022- [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
23- [ ] I updated/added relevant documentation (doc comments with `///`).
24- [ ] All existing and new tests are passing.
25- [ ] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
Michael Goderbauerf6036422019-02-20 15:41:28 -080026- [ ] I am willing to follow-up on review comments in a timely manner.
27
28## Breaking Change
29
Michael Goderbauer0bc94f22019-02-20 18:40:33 -080030Does your PR require Flutter developers to manually update their apps to accommodate your change?
Michael Goderbauerf6036422019-02-20 15:41:28 -080031
Ian Hickson1123b712019-03-28 17:44:58 -070032- [ ] Yes, this is a breaking change (Please read [Handling breaking changes]). *Replace this with a link to the e-mail where you asked for input on this proposed change.*
Michael Goderbauerf6036422019-02-20 15:41:28 -080033- [ ] No, this is *not* a breaking change.
34
35<!-- Links -->
36[issue database]: https://github.com/flutter/flutter/issues
37[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
38[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
39[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
40[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
41[CLA]: https://cla.developers.google.com/
42[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes