Review from Stuart
diff --git a/script/l10n/.gitignore b/script/l10n/.gitignore deleted file mode 100644 index e4ce6a1..0000000 --- a/script/l10n/.gitignore +++ /dev/null
@@ -1,3 +0,0 @@ -# https://dart.dev/tools/private-files -# Created by `dart pub` -.dart_tool/
diff --git a/script/l10n/bin/gen_localizations.dart b/script/l10n/bin/gen_localizations.dart index 8f4e7f1..40aeb93 100644 --- a/script/l10n/bin/gen_localizations.dart +++ b/script/l10n/bin/gen_localizations.dart
@@ -29,14 +29,14 @@ // The following outputs the generated Dart code to the console as a dry run: // // ``` -// dart dev/tools/localization/bin/gen_localizations.dart +// dart script/l10n/bin/gen_localizations.dart // ``` // // If you have removed localizations from the canonical localizations, then // add the '--remove-undefined' flag to also remove them from the other files. // // ``` -// dart dev/tools/localization/bin/gen_localizations.dart --remove-undefined +// dart script/l10n/bin/gen_localizations.dart --remove-undefined // ``` // // If the data looks good, use the `-w` or `--overwrite` option to overwrite the @@ -45,7 +45,7 @@ // packages/flutter_localizations/lib/l10n/: // // ``` -// dart dev/tools/localization/bin/gen_localizations.dart --overwrite +// dart script/l10n/bin/gen_localizations.dart --overwrite // ``` import 'dart:io';
diff --git a/script/l10n/bin/gen_missing_localizations.dart b/script/l10n/bin/gen_missing_localizations.dart index 7d7b880..808faeb 100755 --- a/script/l10n/bin/gen_missing_localizations.dart +++ b/script/l10n/bin/gen_missing_localizations.dart
@@ -15,7 +15,7 @@ // Run this program from the root of the git repository. // // ``` -// dart dev/tools/localization/bin/gen_missing_localizations.dart +// dart script/l10n/bin/gen_missing_localizations.dart // ``` import 'dart:convert'; @@ -26,6 +26,8 @@ import 'package:path/path.dart' as path; +// ignore_for_file: avoid_print + Future<void> main(List<String> rawArgs) async { var removeUndefined = false; if (rawArgs.contains('--remove-undefined')) { @@ -140,7 +142,6 @@ return found; }); if (shouldWrite) { - // ignore: avoid_print print('Updating $entityPath by removing extra entries for $extraResources'); } } @@ -161,7 +162,6 @@ ), ); shouldWrite = true; - // ignore: avoid_print print('Updating $entityPath with missing entries for $missingResources'); } if (shouldWrite) {
diff --git a/script/l10n/pubspec.yaml b/script/l10n/pubspec.yaml index a74d142..d22c5b9 100644 --- a/script/l10n/pubspec.yaml +++ b/script/l10n/pubspec.yaml
@@ -1,7 +1,7 @@ name: l10n description: Generates localizations for material_ui and cupertino_ui. version: 1.0.0 -# repository: https://github.com/flutter/packages/tree/main/script/l10n +publish_to: none environment: sdk: ^3.12.0 @@ -12,5 +12,4 @@ path: ^1.9.0 dev_dependencies: - lints: ^6.0.0 test: ^1.25.6