[webview_flutter] Disable flaky test on iOS (#4525)
The test 'can open new window and go back' periodically times out on
iOS, often for all runs that happen within a certain period. This is
flaking often enough to have a noticable effect on tree greenness, so is
being disabled until we can investigate further.
See https://github.com/flutter/flutter/issues/90976
diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart
index a637da1..45a72d8 100644
--- a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart
+++ b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart
@@ -28,10 +28,6 @@
const String primaryUrl = 'https://flutter.dev/';
const String secondaryUrl = 'https://www.google.com/robots.txt';
- // Set to `false` to include all flaky tests in the test run. See also https://github.com/flutter/flutter/issues/86757.
- const bool _skipDueToIssue86757 = false;
-
- // TODO(bparrishMines): skipped due to https://github.com/flutter/flutter/issues/86757.
testWidgets('initialUrl', (WidgetTester tester) async {
final Completer<WebViewController> controllerCompleter =
Completer<WebViewController>();
@@ -50,9 +46,8 @@
final WebViewController controller = await controllerCompleter.future;
final String? currentUrl = await controller.currentUrl();
expect(currentUrl, primaryUrl);
- }, skip: _skipDueToIssue86757);
+ });
- // TODO(bparrishMines): skipped due to https://github.com/flutter/flutter/issues/86757.
testWidgets('loadUrl', (WidgetTester tester) async {
final Completer<WebViewController> controllerCompleter =
Completer<WebViewController>();
@@ -72,7 +67,7 @@
await controller.loadUrl(secondaryUrl);
final String? currentUrl = await controller.currentUrl();
expect(currentUrl, secondaryUrl);
- }, skip: _skipDueToIssue86757);
+ });
testWidgets('evaluateJavascript', (WidgetTester tester) async {
final Completer<WebViewController> controllerCompleter =
@@ -1106,7 +1101,6 @@
expect(currentUrl, primaryUrl);
});
- // TODO(bparrishMines): skipped due to https://github.com/flutter/flutter/issues/86757.
testWidgets(
'can open new window and go back',
(WidgetTester tester) async {
@@ -1144,7 +1138,8 @@
await pageLoaded.future;
expect(controller.currentUrl(), completion(primaryUrl));
},
- skip: _skipDueToIssue86757,
+ // Flaky; see https://github.com/flutter/flutter/issues/90976
+ skip: true,
);
}
