Fix behavior of constructor for named FirebaseApps (#454)
diff --git a/packages/firebase_core/CHANGELOG.md b/packages/firebase_core/CHANGELOG.md index df6ee93..9beb691 100644 --- a/packages/firebase_core/CHANGELOG.md +++ b/packages/firebase_core/CHANGELOG.md
@@ -1,3 +1,7 @@ +## 0.1.1 + +* Fix behavior of constructor for named Firebase apps. + ## 0.1.0 * **Breaking change**. Set SDK constraints to match the Flutter beta release.
diff --git a/packages/firebase_core/lib/src/firebase_app.dart b/packages/firebase_core/lib/src/firebase_app.dart index 174655a..eb8bfb5 100644 --- a/packages/firebase_core/lib/src/firebase_app.dart +++ b/packages/firebase_core/lib/src/firebase_app.dart
@@ -25,7 +25,7 @@ /// Returns a previously created FirebaseApp instance with the given name, /// or null if no such app exists. - factory FirebaseApp.named(String name) => _namedApps['name']; + factory FirebaseApp.named(String name) => _namedApps[name]; /// Configures an app with the given name. ///
diff --git a/packages/firebase_core/pubspec.yaml b/packages/firebase_core/pubspec.yaml index 85c30b2..7e6f4e9 100644 --- a/packages/firebase_core/pubspec.yaml +++ b/packages/firebase_core/pubspec.yaml
@@ -3,7 +3,7 @@ Firebase apps. author: Flutter Team <flutter-dev@googlegroups.com> homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_core -version: 0.1.0 +version: 0.1.1 flutter: plugin:
diff --git a/packages/firebase_core/test/firebase_core_test.dart b/packages/firebase_core/test/firebase_core_test.dart index 7835628..9e9f267 100755 --- a/packages/firebase_core/test/firebase_core_test.dart +++ b/packages/firebase_core/test/firebase_core_test.dart
@@ -10,7 +10,7 @@ group('$FirebaseApp', () { final List<MethodCall> log = <MethodCall>[]; const FirebaseApp testApp = const FirebaseApp( - name: 'foo', + name: 'testApp', options: const FirebaseOptions(googleAppID: '12345'), ); @@ -34,7 +34,7 @@ }); test('configure', () async { - final String name = 'foo'; + final String name = 'configuredApp'; const FirebaseOptions options = const FirebaseOptions( apiKey: 'testAPIKey', bundleID: 'testBundleID', @@ -54,6 +54,7 @@ ); expect(app.name, equals(name)); expect(app.options, equals(options)); + expect(app, equals(new FirebaseApp.named(app.name))); expect( log, <Matcher>[