[android_intent] Fix pedantic linter errors (#2310)
diff --git a/packages/android_intent/CHANGELOG.md b/packages/android_intent/CHANGELOG.md
index de7b818..76db8d1 100644
--- a/packages/android_intent/CHANGELOG.md
+++ b/packages/android_intent/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.3.4+7
+
+* Fix pedantic linter errors.
+
## 0.3.4+6
* Add missing DartDocs for public members.
diff --git a/packages/android_intent/analysis_options.yaml b/packages/android_intent/analysis_options.yaml
deleted file mode 100644
index 0eab8e5..0000000
--- a/packages/android_intent/analysis_options.yaml
+++ /dev/null
@@ -1,11 +0,0 @@
-# This is a temporary file to allow us to land a new set of linter rules in a
-# series of manageable patches instead of one gigantic PR. It disables some of
-# the new lints that are already failing on this plugin, for this plugin. It
-# should be deleted and the failing lints addressed as soon as possible.
-
-include: ../../analysis_options.yaml
-
-analyzer:
- errors:
- avoid_relative_lib_imports: ignore
- unawaited_futures: ignore
diff --git a/packages/android_intent/example/test_driver/android_intent_e2e.dart b/packages/android_intent/example/test_driver/android_intent_e2e.dart
index 8df8146..2c45262 100644
--- a/packages/android_intent/example/test_driver/android_intent_e2e.dart
+++ b/packages/android_intent/example/test_driver/android_intent_e2e.dart
@@ -1,13 +1,12 @@
import 'dart:io';
+import 'package:android_intent/android_intent.dart';
import 'package:android_intent_example/main.dart';
import 'package:e2e/e2e.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
-import '../../lib/android_intent.dart';
-
/// This is a smoke test that verifies that the example app builds and loads.
/// Because this plugin works by launching Android platform UIs it's not
/// possible to meaningfully test it through its Dart interface currently. There
diff --git a/packages/android_intent/example/test_driver/android_intent_e2e_test.dart b/packages/android_intent/example/test_driver/android_intent_e2e_test.dart
index 4f38746..6147d44 100644
--- a/packages/android_intent/example/test_driver/android_intent_e2e_test.dart
+++ b/packages/android_intent/example/test_driver/android_intent_e2e_test.dart
@@ -7,6 +7,6 @@
final FlutterDriver driver = await FlutterDriver.connect();
final String result =
await driver.requestData(null, timeout: const Duration(minutes: 1));
- driver.close();
+ await driver.close();
exit(result == 'pass' ? 0 : 1);
}
diff --git a/packages/android_intent/pubspec.yaml b/packages/android_intent/pubspec.yaml
index 3048d5b..85b83b5 100644
--- a/packages/android_intent/pubspec.yaml
+++ b/packages/android_intent/pubspec.yaml
@@ -2,7 +2,7 @@
description: Flutter plugin for launching Android Intents. Not supported on iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/android_intent
-version: 0.3.4+6
+version: 0.3.4+7
flutter:
plugin:
diff --git a/packages/android_intent/test/android_intent_test.dart b/packages/android_intent/test/android_intent_test.dart
index b13438b..5562159 100644
--- a/packages/android_intent/test/android_intent_test.dart
+++ b/packages/android_intent/test/android_intent_test.dart
@@ -23,7 +23,7 @@
flags: <int>[Flag.FLAG_ACTIVITY_NEW_TASK],
channel: mockChannel,
platform: FakePlatform(operatingSystem: 'android'));
- androidIntent.launch();
+ await androidIntent.launch();
verify(mockChannel.invokeMethod<void>('launch', <String, Object>{
'action': 'action_view',
'data': Uri.encodeFull('https://flutter.io'),
@@ -35,7 +35,7 @@
action: null,
channel: mockChannel,
platform: FakePlatform(operatingSystem: 'android'));
- androidIntent.launch();
+ await androidIntent.launch();
verify(mockChannel.invokeMethod<void>('launch', <String, Object>{
'action': null,
}));
@@ -46,7 +46,7 @@
action: null,
channel: mockChannel,
platform: FakePlatform(operatingSystem: 'ios'));
- androidIntent.launch();
+ await androidIntent.launch();
verifyZeroInteractions(mockChannel);
});
});
