[connectivity_platform_interface] Remove Platform asserts from MethodChannel. (#2715)
Having dart:io imports in the MethodChannel implementation breaks the pana analysis of federated implementations for platforms where those imports are forbidden (like web).
This change removes the Platform check asserts from the MethodChannel implementation.
diff --git a/packages/connectivity/connectivity_platform_interface/CHANGELOG.md b/packages/connectivity/connectivity_platform_interface/CHANGELOG.md
index 6a06793..1b3ce38 100644
--- a/packages/connectivity/connectivity_platform_interface/CHANGELOG.md
+++ b/packages/connectivity/connectivity_platform_interface/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.0.5
+
+* Remove dart:io Platform checks from the MethodChannel implementation. This is
+tripping the analysis of other versions of the plugin.
+
## 1.0.4
* Bump the minimum Flutter version to 1.12.13+hotfix.5.
diff --git a/packages/connectivity/connectivity_platform_interface/lib/src/method_channel_connectivity.dart b/packages/connectivity/connectivity_platform_interface/lib/src/method_channel_connectivity.dart
index 7a64115..87deaa2 100644
--- a/packages/connectivity/connectivity_platform_interface/lib/src/method_channel_connectivity.dart
+++ b/packages/connectivity/connectivity_platform_interface/lib/src/method_channel_connectivity.dart
@@ -3,7 +3,6 @@
// found in the LICENSE file.
import 'dart:async';
-import 'dart:io' show Platform;
import 'package:connectivity_platform_interface/connectivity_platform_interface.dart';
import 'package:flutter/services.dart';
@@ -68,9 +67,6 @@
Future<LocationAuthorizationStatus> requestLocationServiceAuthorization({
bool requestAlwaysLocationUsage = false,
}) {
- // `assert(Platform.isIOS)` will prevent us from doing dart side unit testing.
- // TODO: These should noop for non-Android, instead of throwing, so people don't need to rely on dart:io for this.
- assert(!Platform.isAndroid);
return methodChannel.invokeMethod<String>(
'requestLocationServiceAuthorization', <bool>[
requestAlwaysLocationUsage
@@ -79,8 +75,6 @@
@override
Future<LocationAuthorizationStatus> getLocationServiceAuthorization() {
- // `assert(Platform.isIOS)` will prevent us from doing dart side unit testing.
- assert(!Platform.isAndroid);
return methodChannel
.invokeMethod<String>('getLocationServiceAuthorization')
.then(parseLocationAuthorizationStatus);
diff --git a/packages/connectivity/connectivity_platform_interface/pubspec.yaml b/packages/connectivity/connectivity_platform_interface/pubspec.yaml
index c5a1e6c..5accb32 100644
--- a/packages/connectivity/connectivity_platform_interface/pubspec.yaml
+++ b/packages/connectivity/connectivity_platform_interface/pubspec.yaml
@@ -3,7 +3,7 @@
homepage: https://github.com/flutter/plugins/tree/master/packages/connectivity/connectivity_platform_interface
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
-version: 1.0.4
+version: 1.0.5
dependencies:
flutter:
