[file_selector] Use const instead of final for XTypeGroup. (#6542)
diff --git a/packages/file_selector/file_selector/CHANGELOG.md b/packages/file_selector/file_selector/CHANGELOG.md
index 1cecd56..06d0109 100644
--- a/packages/file_selector/file_selector/CHANGELOG.md
+++ b/packages/file_selector/file_selector/CHANGELOG.md
@@ -1,5 +1,6 @@
-## NEXT
+## 0.9.2+1
+* Changes XTypeGroup initialization from final to const.
* Updates minimum Flutter version to 2.10.
## 0.9.2
diff --git a/packages/file_selector/file_selector/README.md b/packages/file_selector/file_selector/README.md
index d5fb2d3..9743358 100644
--- a/packages/file_selector/file_selector/README.md
+++ b/packages/file_selector/file_selector/README.md
@@ -34,7 +34,7 @@
#### Open a single file
<?code-excerpt "open_image_page.dart (SingleOpen)"?>
``` dart
-final XTypeGroup typeGroup = XTypeGroup(
+const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
extensions: <String>['jpg', 'png'],
);
@@ -45,11 +45,11 @@
#### Open multiple files at once
<?code-excerpt "open_multiple_images_page.dart (MultiOpen)"?>
``` dart
-final XTypeGroup jpgsTypeGroup = XTypeGroup(
+const XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
extensions: <String>['jpg', 'jpeg'],
);
-final XTypeGroup pngTypeGroup = XTypeGroup(
+const XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
extensions: <String>['png'],
);
diff --git a/packages/file_selector/file_selector/example/lib/open_image_page.dart b/packages/file_selector/file_selector/example/lib/open_image_page.dart
index b72d4e5..ba18e6e 100644
--- a/packages/file_selector/file_selector/example/lib/open_image_page.dart
+++ b/packages/file_selector/file_selector/example/lib/open_image_page.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_constructors, prefer_const_literals_to_create_immutables
-
import 'dart:io';
import 'package:file_selector/file_selector.dart';
@@ -18,7 +15,7 @@
Future<void> _openImageFile(BuildContext context) async {
// #docregion SingleOpen
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
extensions: <String>['jpg', 'png'],
);
diff --git a/packages/file_selector/file_selector/example/lib/open_multiple_images_page.dart b/packages/file_selector/file_selector/example/lib/open_multiple_images_page.dart
index 87549e0..8ae83c2 100644
--- a/packages/file_selector/file_selector/example/lib/open_multiple_images_page.dart
+++ b/packages/file_selector/file_selector/example/lib/open_multiple_images_page.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_constructors, prefer_const_literals_to_create_immutables
-
import 'dart:io';
import 'package:file_selector/file_selector.dart';
@@ -18,11 +15,11 @@
Future<void> _openImageFile(BuildContext context) async {
// #docregion MultiOpen
- final XTypeGroup jpgsTypeGroup = XTypeGroup(
+ const XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
extensions: <String>['jpg', 'jpeg'],
);
- final XTypeGroup pngTypeGroup = XTypeGroup(
+ const XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
extensions: <String>['png'],
);
diff --git a/packages/file_selector/file_selector/example/lib/open_text_page.dart b/packages/file_selector/file_selector/example/lib/open_text_page.dart
index 04d48af..f052db1 100644
--- a/packages/file_selector/file_selector/example/lib/open_text_page.dart
+++ b/packages/file_selector/file_selector/example/lib/open_text_page.dart
@@ -12,12 +12,8 @@
const OpenTextPage({Key? key}) : super(key: key);
Future<void> _openTextFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'text',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
// This demonstrates using an initial directory for the prompt, which should
diff --git a/packages/file_selector/file_selector/pubspec.yaml b/packages/file_selector/file_selector/pubspec.yaml
index 556ddf2..cae08e4 100644
--- a/packages/file_selector/file_selector/pubspec.yaml
+++ b/packages/file_selector/file_selector/pubspec.yaml
@@ -3,7 +3,7 @@
directories, using native file selection UI.
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.9.2
+version: 0.9.2+1
environment:
sdk: ">=2.12.0 <3.0.0"
@@ -27,7 +27,7 @@
file_selector_ios: ^0.5.0
file_selector_linux: ^0.9.0
file_selector_macos: ^0.9.0
- file_selector_platform_interface: ^2.0.0
+ file_selector_platform_interface: ^2.2.0
file_selector_web: ^0.9.0
file_selector_windows: ^0.9.0
flutter:
diff --git a/packages/file_selector/file_selector/test/file_selector_test.dart b/packages/file_selector/file_selector/test/file_selector_test.dart
index 0bef946..13c986b 100644
--- a/packages/file_selector/file_selector/test/file_selector_test.dart
+++ b/packages/file_selector/file_selector/test/file_selector_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'package:file_selector/file_selector.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter_test/flutter_test.dart';
@@ -15,15 +12,11 @@
const String initialDirectory = '/home/flutteruser';
const String confirmButtonText = 'Use this profile picture';
const String suggestedName = 'suggested_name';
- final List<XTypeGroup> acceptedTypeGroups = <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
+ const List<XTypeGroup> acceptedTypeGroups = <XTypeGroup>[
XTypeGroup(label: 'documents', mimeTypes: <String>[
'application/msword',
'application/vnd.openxmlformats-officedocument.wordprocessing',
]),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'images', extensions: <String>[
'jpg',
'png',
diff --git a/packages/file_selector/file_selector_ios/CHANGELOG.md b/packages/file_selector/file_selector_ios/CHANGELOG.md
index 2b2d2f8..439e1d4 100644
--- a/packages/file_selector/file_selector_ios/CHANGELOG.md
+++ b/packages/file_selector/file_selector_ios/CHANGELOG.md
@@ -1,5 +1,6 @@
-## NEXT
+## 0.5.0+2
+* Changes XTypeGroup initialization from final to const.
* Updates minimum Flutter version to 2.10.
## 0.5.0+1
diff --git a/packages/file_selector/file_selector_ios/example/lib/open_image_page.dart b/packages/file_selector/file_selector_ios/example/lib/open_image_page.dart
index eff6c4f..606a648 100644
--- a/packages/file_selector/file_selector_ios/example/lib/open_image_page.dart
+++ b/packages/file_selector/file_selector_ios/example/lib/open_image_page.dart
@@ -15,15 +15,9 @@
const OpenImagePage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
macUTIs: <String>['public.image'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_ios/example/lib/open_multiple_images_page.dart b/packages/file_selector/file_selector_ios/example/lib/open_multiple_images_page.dart
index 0035ebc..adc4a65 100644
--- a/packages/file_selector/file_selector_ios/example/lib/open_multiple_images_page.dart
+++ b/packages/file_selector/file_selector_ios/example/lib/open_multiple_images_page.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'dart:io';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
@@ -18,16 +15,12 @@
const OpenMultipleImagesPage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup jpgsTypeGroup = XTypeGroup(
+ const XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
extensions: <String>['jpg', 'jpeg'],
macUTIs: <String>['public.jpeg'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup pngTypeGroup = XTypeGroup(
+ const XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
extensions: <String>['png'],
macUTIs: <String>['public.png'],
diff --git a/packages/file_selector/file_selector_ios/example/lib/open_text_page.dart b/packages/file_selector/file_selector_ios/example/lib/open_text_page.dart
index b91195e..e7bbf8b 100644
--- a/packages/file_selector/file_selector_ios/example/lib/open_text_page.dart
+++ b/packages/file_selector/file_selector_ios/example/lib/open_text_page.dart
@@ -12,15 +12,9 @@
const OpenTextPage({Key? key}) : super(key: key);
Future<void> _openTextFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'text',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
macUTIs: <String>['public.text'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_ios/example/pubspec.yaml b/packages/file_selector/file_selector_ios/example/pubspec.yaml
index eae4a2b..5a2eaa6 100644
--- a/packages/file_selector/file_selector_ios/example/pubspec.yaml
+++ b/packages/file_selector/file_selector_ios/example/pubspec.yaml
@@ -17,7 +17,7 @@
# The example app is bundled with the plugin so we use a path dependency on
# the parent directory to use the current plugin's version.
path: ..
- file_selector_platform_interface: ^2.0.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_ios/pubspec.yaml b/packages/file_selector/file_selector_ios/pubspec.yaml
index b69db86..3f8ecfa 100644
--- a/packages/file_selector/file_selector_ios/pubspec.yaml
+++ b/packages/file_selector/file_selector_ios/pubspec.yaml
@@ -2,7 +2,7 @@
description: iOS implementation of the file_selector plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.5.0+1
+version: 0.5.0+2
environment:
sdk: ">=2.14.4 <3.0.0"
@@ -17,7 +17,7 @@
pluginClass: FFSFileSelectorPlugin
dependencies:
- file_selector_platform_interface: ^2.1.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_ios/test/file_selector_ios_test.dart b/packages/file_selector/file_selector_ios/test/file_selector_ios_test.dart
index a388fe9..f66bd7d 100644
--- a/packages/file_selector/file_selector_ios/test/file_selector_ios_test.dart
+++ b/packages/file_selector/file_selector_ios/test/file_selector_ios_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'package:file_selector_ios/file_selector_ios.dart';
import 'package:file_selector_ios/src/messages.g.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
@@ -39,18 +36,14 @@
});
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -69,9 +62,7 @@
expect(config.allowMultiSelection, isFalse);
});
test('throws for a type group that does not support iOS', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -82,9 +73,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
@@ -99,18 +88,14 @@
});
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -129,9 +114,7 @@
expect(config.allowMultiSelection, isTrue);
});
test('throws for a type group that does not support iOS', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -142,9 +125,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
diff --git a/packages/file_selector/file_selector_linux/CHANGELOG.md b/packages/file_selector/file_selector_linux/CHANGELOG.md
index d76c635..a1f57b5 100644
--- a/packages/file_selector/file_selector_linux/CHANGELOG.md
+++ b/packages/file_selector/file_selector_linux/CHANGELOG.md
@@ -1,5 +1,6 @@
-## NEXT
+## 0.9.0+1
+* Changes XTypeGroup initialization from final to const.
* Updates minimum Flutter version to 2.10.
## 0.9.0
diff --git a/packages/file_selector/file_selector_linux/example/lib/open_image_page.dart b/packages/file_selector/file_selector_linux/example/lib/open_image_page.dart
index 1925b27..b6ada56 100644
--- a/packages/file_selector/file_selector_linux/example/lib/open_image_page.dart
+++ b/packages/file_selector/file_selector_linux/example/lib/open_image_page.dart
@@ -15,12 +15,8 @@
const OpenImagePage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart b/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
index ee7e7d1..c8e352a 100644
--- a/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
+++ b/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
@@ -15,20 +15,12 @@
const OpenMultipleImagesPage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup jpgsTypeGroup = XTypeGroup(
+ const XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'jpeg'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup pngTypeGroup = XTypeGroup(
+ const XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['png'],
);
final List<XFile> files = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_linux/example/lib/open_text_page.dart b/packages/file_selector/file_selector_linux/example/lib/open_text_page.dart
index d5e8d46..4c88d74 100644
--- a/packages/file_selector/file_selector_linux/example/lib/open_text_page.dart
+++ b/packages/file_selector/file_selector_linux/example/lib/open_text_page.dart
@@ -12,12 +12,8 @@
const OpenTextPage({Key? key}) : super(key: key);
Future<void> _openTextFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'text',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_linux/example/pubspec.yaml b/packages/file_selector/file_selector_linux/example/pubspec.yaml
index 857c950..51bdb28 100644
--- a/packages/file_selector/file_selector_linux/example/pubspec.yaml
+++ b/packages/file_selector/file_selector_linux/example/pubspec.yaml
@@ -9,7 +9,7 @@
dependencies:
file_selector_linux:
path: ../
- file_selector_platform_interface: ^2.0.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_linux/pubspec.yaml b/packages/file_selector/file_selector_linux/pubspec.yaml
index e0b26d1..a8aea37 100644
--- a/packages/file_selector/file_selector_linux/pubspec.yaml
+++ b/packages/file_selector/file_selector_linux/pubspec.yaml
@@ -2,7 +2,7 @@
description: Liunx implementation of the file_selector plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector_linux
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.9.0
+version: 0.9.0+1
environment:
sdk: ">=2.12.0 <3.0.0"
@@ -18,7 +18,7 @@
dependencies:
cross_file: ^0.3.1
- file_selector_platform_interface: ^2.1.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_linux/test/file_selector_linux_test.dart b/packages/file_selector/file_selector_linux/test/file_selector_linux_test.dart
index 54111c2..748f922 100644
--- a/packages/file_selector/file_selector_linux/test/file_selector_linux_test.dart
+++ b/packages/file_selector/file_selector_linux/test/file_selector_linux_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'package:file_selector_linux/file_selector_linux.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter/services.dart';
@@ -32,18 +29,14 @@
group('#openFile', () {
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -108,9 +101,7 @@
});
test('throws for a type group that does not support Linux', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -121,9 +112,7 @@
});
test('passes a wildcard group correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'any',
);
@@ -150,18 +139,14 @@
group('#openFiles', () {
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -226,9 +211,7 @@
});
test('throws for a type group that does not support Linux', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -239,9 +222,7 @@
});
test('passes a wildcard group correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'any',
);
@@ -268,18 +249,14 @@
group('#getSavePath', () {
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -345,9 +322,7 @@
});
test('throws for a type group that does not support Linux', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -358,9 +333,7 @@
});
test('passes a wildcard group correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'any',
);
diff --git a/packages/file_selector/file_selector_macos/CHANGELOG.md b/packages/file_selector/file_selector_macos/CHANGELOG.md
index f9241da..af17db8 100644
--- a/packages/file_selector/file_selector_macos/CHANGELOG.md
+++ b/packages/file_selector/file_selector_macos/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.9.0+3
+
+* Changes XTypeGroup initialization from final to const.
+
## 0.9.0+2
* Updates imports for `prefer_relative_imports`.
diff --git a/packages/file_selector/file_selector_macos/example/lib/open_image_page.dart b/packages/file_selector/file_selector_macos/example/lib/open_image_page.dart
index 1925b27..b6ada56 100644
--- a/packages/file_selector/file_selector_macos/example/lib/open_image_page.dart
+++ b/packages/file_selector/file_selector_macos/example/lib/open_image_page.dart
@@ -15,12 +15,8 @@
const OpenImagePage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_macos/example/lib/open_multiple_images_page.dart b/packages/file_selector/file_selector_macos/example/lib/open_multiple_images_page.dart
index ee7e7d1..c8e352a 100644
--- a/packages/file_selector/file_selector_macos/example/lib/open_multiple_images_page.dart
+++ b/packages/file_selector/file_selector_macos/example/lib/open_multiple_images_page.dart
@@ -15,20 +15,12 @@
const OpenMultipleImagesPage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup jpgsTypeGroup = XTypeGroup(
+ const XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'jpeg'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup pngTypeGroup = XTypeGroup(
+ const XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['png'],
);
final List<XFile> files = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_macos/example/lib/open_text_page.dart b/packages/file_selector/file_selector_macos/example/lib/open_text_page.dart
index d5e8d46..4c88d74 100644
--- a/packages/file_selector/file_selector_macos/example/lib/open_text_page.dart
+++ b/packages/file_selector/file_selector_macos/example/lib/open_text_page.dart
@@ -12,12 +12,8 @@
const OpenTextPage({Key? key}) : super(key: key);
Future<void> _openTextFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'text',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_macos/example/pubspec.yaml b/packages/file_selector/file_selector_macos/example/pubspec.yaml
index 58c5d6e..d3f3114 100644
--- a/packages/file_selector/file_selector_macos/example/pubspec.yaml
+++ b/packages/file_selector/file_selector_macos/example/pubspec.yaml
@@ -15,7 +15,7 @@
# The example app is bundled with the plugin so we use a path dependency on
# the parent directory to use the current plugin's version.
path: ..
- file_selector_platform_interface: ^2.0.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_macos/pubspec.yaml b/packages/file_selector/file_selector_macos/pubspec.yaml
index b921cc8..3fc3832 100644
--- a/packages/file_selector/file_selector_macos/pubspec.yaml
+++ b/packages/file_selector/file_selector_macos/pubspec.yaml
@@ -2,7 +2,7 @@
description: macOS implementation of the file_selector plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector_macos
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.9.0+2
+version: 0.9.0+3
environment:
sdk: ">=2.12.0 <3.0.0"
@@ -18,7 +18,7 @@
dependencies:
cross_file: ^0.3.1
- file_selector_platform_interface: ^2.1.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_macos/test/file_selector_macos_test.dart b/packages/file_selector/file_selector_macos/test/file_selector_macos_test.dart
index 29702a5..789d70a 100644
--- a/packages/file_selector/file_selector_macos/test/file_selector_macos_test.dart
+++ b/packages/file_selector/file_selector_macos/test/file_selector_macos_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'package:file_selector_macos/file_selector_macos.dart';
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter/services.dart';
@@ -33,18 +30,14 @@
group('openFile', () {
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -103,9 +96,7 @@
});
test('throws for a type group that does not support macOS', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -116,9 +107,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
@@ -129,18 +118,14 @@
group('openFiles', () {
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -199,9 +184,7 @@
});
test('throws for a type group that does not support macOS', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -212,9 +195,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
@@ -225,18 +206,14 @@
group('getSavePath', () {
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -296,9 +273,7 @@
});
test('throws for a type group that does not support macOS', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'images',
webWildCards: <String>['images/*'],
);
@@ -309,9 +284,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
@@ -353,25 +326,19 @@
test('ignores all type groups if any of them is a wildcard', () async {
await plugin.getSavePath(acceptedTypeGroups: <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- XTypeGroup(
+ const XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- XTypeGroup(
+ const XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
macUTIs: <String>['public.image'],
),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- XTypeGroup(
+ const XTypeGroup(
label: 'any',
),
]);
diff --git a/packages/file_selector/file_selector_platform_interface/test/x_type_group_test.dart b/packages/file_selector/file_selector_platform_interface/test/x_type_group_test.dart
index 107cdc3..c5e65d0 100644
--- a/packages/file_selector/file_selector_platform_interface/test/x_type_group_test.dart
+++ b/packages/file_selector/file_selector_platform_interface/test/x_type_group_test.dart
@@ -9,12 +9,12 @@
group('XTypeGroup', () {
test('toJSON() creates correct map', () {
const String label = 'test group';
- final List<String> extensions = <String>['txt', 'jpg'];
- final List<String> mimeTypes = <String>['text/plain'];
- final List<String> macUTIs = <String>['public.plain-text'];
- final List<String> webWildCards = <String>['image/*'];
+ const List<String> extensions = <String>['txt', 'jpg'];
+ const List<String> mimeTypes = <String>['text/plain'];
+ const List<String> macUTIs = <String>['public.plain-text'];
+ const List<String> webWildCards = <String>['image/*'];
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: label,
extensions: extensions,
mimeTypes: mimeTypes,
@@ -72,8 +72,8 @@
});
test('Leading dots are removed from extensions', () {
- final List<String> extensions = <String>['.txt', '.jpg'];
- final XTypeGroup group = XTypeGroup(extensions: extensions);
+ const List<String> extensions = <String>['.txt', '.jpg'];
+ const XTypeGroup group = XTypeGroup(extensions: extensions);
expect(group.extensions, <String>['txt', 'jpg']);
});
diff --git a/packages/file_selector/file_selector_web/CHANGELOG.md b/packages/file_selector/file_selector_web/CHANGELOG.md
index 69ca203..5e531bb 100644
--- a/packages/file_selector/file_selector_web/CHANGELOG.md
+++ b/packages/file_selector/file_selector_web/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.9.0+2
+
+* Changes XTypeGroup initialization from final to const.
+
## 0.9.0+1
* Updates imports for `prefer_relative_imports`.
diff --git a/packages/file_selector/file_selector_web/example/integration_test/file_selector_web_test.dart b/packages/file_selector/file_selector_web/example/integration_test/file_selector_web_test.dart
index 5f476d9..664c408 100644
--- a/packages/file_selector/file_selector_web/example/integration_test/file_selector_web_test.dart
+++ b/packages/file_selector/file_selector_web/example/integration_test/file_selector_web_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'dart:html';
import 'dart:typed_data';
@@ -29,9 +26,7 @@
final FileSelectorWeb plugin =
FileSelectorWeb(domHelper: mockDomHelper);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
extensions: <String>['jpg', 'jpeg'],
mimeTypes: <String>['image/png'],
@@ -61,9 +56,7 @@
final FileSelectorWeb plugin =
FileSelectorWeb(domHelper: mockDomHelper);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'files',
extensions: <String>['.txt'],
);
diff --git a/packages/file_selector/file_selector_web/example/pubspec.yaml b/packages/file_selector/file_selector_web/example/pubspec.yaml
index 3a36ce5..e14f5c2 100644
--- a/packages/file_selector/file_selector_web/example/pubspec.yaml
+++ b/packages/file_selector/file_selector_web/example/pubspec.yaml
@@ -6,7 +6,7 @@
flutter: ">=2.10.0"
dependencies:
- file_selector_platform_interface: ^2.1.0
+ file_selector_platform_interface: ^2.2.0
file_selector_web:
path: ../
flutter:
diff --git a/packages/file_selector/file_selector_web/pubspec.yaml b/packages/file_selector/file_selector_web/pubspec.yaml
index 3822958..848a41b 100644
--- a/packages/file_selector/file_selector_web/pubspec.yaml
+++ b/packages/file_selector/file_selector_web/pubspec.yaml
@@ -2,7 +2,7 @@
description: Web platform implementation of file_selector
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.9.0+1
+version: 0.9.0+2
environment:
sdk: ">=2.12.0 <3.0.0"
@@ -17,7 +17,7 @@
fileName: file_selector_web.dart
dependencies:
- file_selector_platform_interface: ^2.1.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
flutter_web_plugins:
diff --git a/packages/file_selector/file_selector_web/test/utils_test.dart b/packages/file_selector/file_selector_web/test/utils_test.dart
index dcb7c3d..f9f3a41 100644
--- a/packages/file_selector/file_selector_web/test/utils_test.dart
+++ b/packages/file_selector/file_selector_web/test/utils_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:file_selector_web/src/utils.dart';
import 'package:flutter_test/flutter_test.dart';
@@ -13,15 +10,9 @@
group('FileSelectorWeb utils', () {
group('acceptedTypesToString', () {
test('works', () {
- final List<XTypeGroup> acceptedTypes = <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
+ const List<XTypeGroup> acceptedTypes = <XTypeGroup>[
XTypeGroup(label: 'images', webWildCards: <String>['images/*']),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'jpgs', extensions: <String>['jpg', 'jpeg']),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'pngs', mimeTypes: <String>['image/png']),
];
final String accepts = acceptedTypesToString(acceptedTypes);
@@ -29,18 +20,14 @@
});
test('works with an empty list', () {
- final List<XTypeGroup> acceptedTypes = <XTypeGroup>[];
+ const List<XTypeGroup> acceptedTypes = <XTypeGroup>[];
final String accepts = acceptedTypesToString(acceptedTypes);
expect(accepts, '');
});
test('works with extensions', () {
- final List<XTypeGroup> acceptedTypes = <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
+ const List<XTypeGroup> acceptedTypes = <XTypeGroup>[
XTypeGroup(label: 'jpgs', extensions: <String>['jpeg', 'jpg']),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'pngs', extensions: <String>['png']),
];
final String accepts = acceptedTypesToString(acceptedTypes);
@@ -48,13 +35,9 @@
});
test('works with mime types', () {
- final List<XTypeGroup> acceptedTypes = <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
+ const List<XTypeGroup> acceptedTypes = <XTypeGroup>[
XTypeGroup(
label: 'jpgs', mimeTypes: <String>['image/jpeg', 'image/jpg']),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'pngs', mimeTypes: <String>['image/png']),
];
final String accepts = acceptedTypesToString(acceptedTypes);
@@ -62,15 +45,9 @@
});
test('works with web wild cards', () {
- final List<XTypeGroup> acceptedTypes = <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
+ const List<XTypeGroup> acceptedTypes = <XTypeGroup>[
XTypeGroup(label: 'images', webWildCards: <String>['image/*']),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'audios', webWildCards: <String>['audio/*']),
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
XTypeGroup(label: 'videos', webWildCards: <String>['video/*']),
];
final String accepts = acceptedTypesToString(acceptedTypes);
@@ -78,9 +55,7 @@
});
test('throws for a type group that does not support web', () {
- final List<XTypeGroup> acceptedTypes = <XTypeGroup>[
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
+ const List<XTypeGroup> acceptedTypes = <XTypeGroup>[
XTypeGroup(label: 'text', macUTIs: <String>['public.text']),
];
expect(() => acceptedTypesToString(acceptedTypes), throwsArgumentError);
diff --git a/packages/file_selector/file_selector_windows/CHANGELOG.md b/packages/file_selector/file_selector_windows/CHANGELOG.md
index 1221bbd..13e895c 100644
--- a/packages/file_selector/file_selector_windows/CHANGELOG.md
+++ b/packages/file_selector/file_selector_windows/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.9.1+4
+
+* Changes XTypeGroup initialization from final to const.
+
## 0.9.1+3
* Updates imports for `prefer_relative_imports`.
diff --git a/packages/file_selector/file_selector_windows/example/lib/open_image_page.dart b/packages/file_selector/file_selector_windows/example/lib/open_image_page.dart
index 1925b27..b6ada56 100644
--- a/packages/file_selector/file_selector_windows/example/lib/open_image_page.dart
+++ b/packages/file_selector/file_selector_windows/example/lib/open_image_page.dart
@@ -15,12 +15,8 @@
const OpenImagePage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'images',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'png'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_windows/example/lib/open_multiple_images_page.dart b/packages/file_selector/file_selector_windows/example/lib/open_multiple_images_page.dart
index ee7e7d1..c8e352a 100644
--- a/packages/file_selector/file_selector_windows/example/lib/open_multiple_images_page.dart
+++ b/packages/file_selector/file_selector_windows/example/lib/open_multiple_images_page.dart
@@ -15,20 +15,12 @@
const OpenMultipleImagesPage({Key? key}) : super(key: key);
Future<void> _openImageFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup jpgsTypeGroup = XTypeGroup(
+ const XTypeGroup jpgsTypeGroup = XTypeGroup(
label: 'JPEGs',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['jpg', 'jpeg'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup pngTypeGroup = XTypeGroup(
+ const XTypeGroup pngTypeGroup = XTypeGroup(
label: 'PNGs',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['png'],
);
final List<XFile> files = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_windows/example/lib/open_text_page.dart b/packages/file_selector/file_selector_windows/example/lib/open_text_page.dart
index d5e8d46..4c88d74 100644
--- a/packages/file_selector/file_selector_windows/example/lib/open_text_page.dart
+++ b/packages/file_selector/file_selector_windows/example/lib/open_text_page.dart
@@ -12,12 +12,8 @@
const OpenTextPage({Key? key}) : super(key: key);
Future<void> _openTextFile(BuildContext context) async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup typeGroup = XTypeGroup(
+ const XTypeGroup typeGroup = XTypeGroup(
label: 'text',
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_literals_to_create_immutables
extensions: <String>['txt', 'json'],
);
final XFile? file = await FileSelectorPlatform.instance
diff --git a/packages/file_selector/file_selector_windows/example/pubspec.yaml b/packages/file_selector/file_selector_windows/example/pubspec.yaml
index 99c251d..bc886d3 100644
--- a/packages/file_selector/file_selector_windows/example/pubspec.yaml
+++ b/packages/file_selector/file_selector_windows/example/pubspec.yaml
@@ -8,7 +8,7 @@
flutter: ">=2.10.0"
dependencies:
- file_selector_platform_interface: ^2.0.0
+ file_selector_platform_interface: ^2.2.0
file_selector_windows:
# When depending on this package from a real application you should use:
# file_selector_windows: ^x.y.z
diff --git a/packages/file_selector/file_selector_windows/pubspec.yaml b/packages/file_selector/file_selector_windows/pubspec.yaml
index 7859822..ee0701b 100644
--- a/packages/file_selector/file_selector_windows/pubspec.yaml
+++ b/packages/file_selector/file_selector_windows/pubspec.yaml
@@ -2,7 +2,7 @@
description: Windows implementation of the file_selector plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector_windows
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.9.1+3
+version: 0.9.1+4
environment:
sdk: ">=2.12.0 <3.0.0"
@@ -18,7 +18,7 @@
dependencies:
cross_file: ^0.3.1
- file_selector_platform_interface: ^2.1.0
+ file_selector_platform_interface: ^2.2.0
flutter:
sdk: flutter
diff --git a/packages/file_selector/file_selector_windows/test/file_selector_windows_test.dart b/packages/file_selector/file_selector_windows/test/file_selector_windows_test.dart
index 2d8dc4b..f07c9b6 100644
--- a/packages/file_selector/file_selector_windows/test/file_selector_windows_test.dart
+++ b/packages/file_selector/file_selector_windows/test/file_selector_windows_test.dart
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
-// ignore_for_file: prefer_const_literals_to_create_immutables
-
import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:file_selector_windows/file_selector_windows.dart';
import 'package:file_selector_windows/src/messages.g.dart';
@@ -50,18 +47,14 @@
});
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -93,9 +86,7 @@
});
test('throws for a type group that does not support Windows', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
mimeTypes: <String>['text/plain'],
);
@@ -106,9 +97,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
@@ -136,18 +125,14 @@
});
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -179,9 +164,7 @@
});
test('throws for a type group that does not support Windows', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
mimeTypes: <String>['text/plain'],
);
@@ -192,9 +175,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
@@ -250,18 +231,14 @@
});
test('passes the accepted type groups correctly', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
extensions: <String>['txt'],
mimeTypes: <String>['text/plain'],
macUTIs: <String>['public.text'],
);
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup groupTwo = XTypeGroup(
+ const XTypeGroup groupTwo = XTypeGroup(
label: 'image',
extensions: <String>['jpg'],
mimeTypes: <String>['image/jpg'],
@@ -300,9 +277,7 @@
});
test('throws for a type group that does not support Windows', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
mimeTypes: <String>['text/plain'],
);
@@ -313,9 +288,7 @@
});
test('allows a wildcard group', () async {
- // TODO(stuartmorgan): https://github.com/flutter/flutter/issues/111906
- // ignore: prefer_const_constructors
- final XTypeGroup group = XTypeGroup(
+ const XTypeGroup group = XTypeGroup(
label: 'text',
);
