[google_sign_in_web] Remove fakeConstructor$ from generated API. (#2602)
JS interop classes do not support non-external constructors.
diff --git a/packages/google_sign_in/google_sign_in_web/CHANGELOG.md b/packages/google_sign_in/google_sign_in_web/CHANGELOG.md
index 7f1e88b..1b1492b 100644
--- a/packages/google_sign_in/google_sign_in_web/CHANGELOG.md
+++ b/packages/google_sign_in/google_sign_in_web/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.8.4
+
+* Remove all `fakeConstructor$` from the generated facade. JS interop classes do not support non-external constructors.
+
## 0.8.3+2
* Make the pedantic dev_dependency explicit.
diff --git a/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapi.dart b/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapi.dart
index c64d93b..97ae9b4 100644
--- a/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapi.dart
+++ b/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapi.dart
@@ -346,10 +346,7 @@
/// HttpRequest supports promises.
/// See Google API Client JavaScript Using Promises https://developers.google.com/api-client-library/javascript/features/promises
@JS("gapi.client.HttpRequestPromise")
-class HttpRequestPromise<T> {
- // @Ignore
- HttpRequestPromise.fakeConstructor$();
-}
+class HttpRequestPromise<T> {}
@JS("gapi.client.HttpRequestPromise")
abstract class _HttpRequestPromise<T> {
@@ -374,9 +371,6 @@
/// An object encapsulating an HTTP request. This object is not instantiated directly, rather it is returned by gapi.client.request.
@JS("gapi.client.HttpRequest")
class HttpRequest<T> extends HttpRequestPromise<T> {
- // @Ignore
- HttpRequest.fakeConstructor$() : super.fakeConstructor$();
-
/// Executes the request and runs the supplied callback on response.
external void execute(
dynamic callback(
@@ -398,9 +392,6 @@
/// Represents an HTTP Batch operation. Individual HTTP requests are added with the add method and the batch is executed using execute.
@JS("gapi.client.HttpBatch")
class HttpBatch {
- // @Ignore
- HttpBatch.fakeConstructor$();
-
/// Adds a gapi.client.HttpRequest to the batch.
external void add(HttpRequest<dynamic> httpRequest,
[dynamic
@@ -436,9 +427,6 @@
/// Similar to gapi.client.HttpRequest except this object encapsulates requests generated by registered methods.
@JS("gapi.client.RpcRequest")
class RpcRequest {
- // @Ignore
- RpcRequest.fakeConstructor$();
-
/// Executes the request and runs the supplied callback with the response.
external void callback(
void callback(
diff --git a/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart b/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart
index 5071f93..e05bedf 100644
--- a/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart
+++ b/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart
@@ -22,8 +22,6 @@
/// request additional scopes, and sign out from the current account.
@JS("gapi.auth2.GoogleAuth")
class GoogleAuth {
- // @Ignore
- GoogleAuth.fakeConstructor$();
external IsSignedIn get isSignedIn;
external set isSignedIn(IsSignedIn v);
external CurrentUser get currentUser;
@@ -212,8 +210,6 @@
@JS("gapi.auth2.SigninOptionsBuilder")
class SigninOptionsBuilder {
- // @Ignore
- SigninOptionsBuilder.fakeConstructor$();
external dynamic setAppPackageName(String name);
external dynamic setFetchBasicProfile(bool fetch);
external dynamic setPrompt(String prompt);
diff --git a/packages/google_sign_in/google_sign_in_web/pubspec.yaml b/packages/google_sign_in/google_sign_in_web/pubspec.yaml
index 91a002b..574cd95 100644
--- a/packages/google_sign_in/google_sign_in_web/pubspec.yaml
+++ b/packages/google_sign_in/google_sign_in_web/pubspec.yaml
@@ -2,7 +2,7 @@
description: Flutter plugin for Google Sign-In, a secure authentication system
for signing in with a Google account on Android, iOS and Web.
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_web
-version: 0.8.3+2
+version: 0.8.4
flutter:
plugin:
