[share] MethodCallHandler.java uses unchecked or unsafe operations (#3004)
diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md
index c4ee830..8037c75 100644
--- a/packages/share/CHANGELOG.md
+++ b/packages/share/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.6.5+1
+
+* Avoiding uses unchecked or unsafe Object Type Casting
+
## 0.6.5
* Added support for sharing files
diff --git a/packages/share/android/build.gradle b/packages/share/android/build.gradle
index 7506f4d..ffa1432 100644
--- a/packages/share/android/build.gradle
+++ b/packages/share/android/build.gradle
@@ -1,5 +1,6 @@
group 'io.flutter.plugins.share'
version '1.0-SNAPSHOT'
+def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"]
buildscript {
repositories {
@@ -19,6 +20,10 @@
}
}
+project.getTasks().withType(JavaCompile){
+ options.compilerArgs.addAll(args)
+}
+
apply plugin: 'com.android.library'
android {
diff --git a/packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java b/packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java
index 02841d3..99baabe 100644
--- a/packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java
+++ b/packages/share/android/src/main/java/io/flutter/plugins/share/MethodCallHandler.java
@@ -25,19 +25,21 @@
case "share":
expectMapArguments(call);
// Android does not support showing the share sheet at a particular point on screen.
- share.share((String) call.argument("text"), (String) call.argument("subject"));
+ String text = call.argument("text");
+ String subject = call.argument("subject");
+ share.share(text, subject);
result.success(null);
break;
case "shareFiles":
expectMapArguments(call);
+ List<String> paths = call.argument("paths");
+ List<String> mimeTypes = call.argument("mimeTypes");
+ text = call.argument("text");
+ subject = call.argument("subject");
// Android does not support showing the share sheet at a particular point on screen.
try {
- share.shareFiles(
- (List<String>) call.argument("paths"),
- (List<String>) call.argument("mimeTypes"),
- (String) call.argument("text"),
- (String) call.argument("subject"));
+ share.shareFiles(paths, mimeTypes, text, subject);
result.success(null);
} catch (IOException e) {
result.error(e.getMessage(), null, null);
diff --git a/packages/share/pubspec.yaml b/packages/share/pubspec.yaml
index 918087b..f9c1f4b 100644
--- a/packages/share/pubspec.yaml
+++ b/packages/share/pubspec.yaml
@@ -5,7 +5,7 @@
# 0.6.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
-version: 0.6.5
+version: 0.6.5+1
flutter:
plugin:
