[url_launcher] remove temporary dependency override (#2401)
Follow-up to #2399 removing the dependency override.
diff --git a/packages/url_launcher/url_launcher/pubspec.yaml b/packages/url_launcher/url_launcher/pubspec.yaml
index 5bb04bd..cd51673 100644
--- a/packages/url_launcher/url_launcher/pubspec.yaml
+++ b/packages/url_launcher/url_launcher/pubspec.yaml
@@ -20,7 +20,7 @@
dependencies:
flutter:
sdk: flutter
- url_launcher_platform_interface: ^1.0.1
+ url_launcher_platform_interface: ^1.0.4
# The design on https://flutter.dev/go/federated-plugins was to leave
# this constraint as "any". We cannot do it right now as it fails pub publish
# validation, so we set a ^ constraint.
@@ -29,13 +29,6 @@
url_launcher_web: ^0.1.0+1
url_launcher_macos: ^0.0.1
-# Temporarily overriding the dependency to keep CI green.
-# WILL REMOVE THIS PRIOR TO PUBLISHING THIS PACKAGE.
-# TODO(amirh): remove after publishing the platform interface
-dependency_overrides:
- url_launcher_platform_interface:
- path: ../url_launcher_platform_interface
-
dev_dependencies:
flutter_test:
sdk: flutter
diff --git a/script/build_all_plugins_app.sh b/script/build_all_plugins_app.sh
index dac8316..94c3f6b 100755
--- a/script/build_all_plugins_app.sh
+++ b/script/build_all_plugins_app.sh
@@ -11,14 +11,18 @@
check_changed_packages > /dev/null
readonly EXCLUDED_PLUGINS_LIST=(
+ "google_sign_in_platform_interface"
+ "google_sign_in_web"
"instrumentation_adapter"
+ "plugin_platform_interface"
+ "shared_preferences_macos"
+ "shared_preferences_platform_interface"
+ "shared_preferences_web"
+ "url_launcher_macos"
"url_launcher_platform_interface"
"url_launcher_web"
- "url_launcher_macos"
- "google_sign_in_platform_interface"
"video_player_platform_interface"
- "shared_preferences_platform_interface"
- "shared_preferences_macos"
+ "video_player_web"
)
# Comma-separated string of the list above
readonly EXCLUDED=$(IFS=, ; echo "${EXCLUDED_PLUGINS_LIST[*]}")
diff --git a/script/check_publish.sh b/script/check_publish.sh
index 68c8b4c..2e53fc8 100755
--- a/script/check_publish.sh
+++ b/script/check_publish.sh
@@ -15,13 +15,6 @@
for dir in $(pub global run flutter_plugin_tools list --plugins="$1"); do
local package_name=$(basename "$dir")
- # Temporarily skipping publish check for url_launcher while it has a
- # dependency override.
- # TODO(amirh): remove this after publishing url_launcher_platform_interface
- if [[ $package_name == "url_launcher" ]]; then
- echo "Skipping publish check for $package_name"
- continue
- fi
echo "Checking that $package_name can be published."
if [[ $(cd "$dir" && cat pubspec.yaml | grep -E "^publish_to: none") ]]; then
echo "Package $package_name is marked as unpublishable. Skipping."
