[video_player_platform_interface] Fix some pedantic lints (#2349)
Fixes unawaited_futures. There are still some undocumented members here
that are unclear to me, so unfortunately the analysis_options.yaml is
still there.
diff --git a/packages/video_player/video_player_platform_interface/CHANGELOG.md b/packages/video_player/video_player_platform_interface/CHANGELOG.md
index 54d9e6b..acaff15 100644
--- a/packages/video_player/video_player_platform_interface/CHANGELOG.md
+++ b/packages/video_player/video_player_platform_interface/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.0.2
+
+* Fix unawaited futures in the tests.
+
## 1.0.1
* Return correct platform event type when buffering
diff --git a/packages/video_player/video_player_platform_interface/analysis_options.yaml b/packages/video_player/video_player_platform_interface/analysis_options.yaml
index e1dadb9..969b557 100644
--- a/packages/video_player/video_player_platform_interface/analysis_options.yaml
+++ b/packages/video_player/video_player_platform_interface/analysis_options.yaml
@@ -8,4 +8,3 @@
analyzer:
errors:
public_member_api_docs: ignore
- unawaited_futures: ignore
diff --git a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
index 46b04d4..d8aa26d 100644
--- a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
+++ b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
@@ -27,6 +27,8 @@
@visibleForTesting
bool get isMock => false;
+ static VideoPlayerPlatform _instance = MethodChannelVideoPlayer();
+
/// The default instance of [VideoPlayerPlatform] to use.
///
/// Platform-specific plugins should override this with their own
@@ -34,8 +36,6 @@
/// register themselves.
///
/// Defaults to [MethodChannelVideoPlayer].
- static VideoPlayerPlatform _instance = MethodChannelVideoPlayer();
-
static VideoPlayerPlatform get instance => _instance;
// TODO(amirh): Extract common platform interface logic.
diff --git a/packages/video_player/video_player_platform_interface/pubspec.yaml b/packages/video_player/video_player_platform_interface/pubspec.yaml
index e36c958..38bde72 100644
--- a/packages/video_player/video_player_platform_interface/pubspec.yaml
+++ b/packages/video_player/video_player_platform_interface/pubspec.yaml
@@ -4,7 +4,7 @@
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_platform_interface
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
-version: 1.0.1
+version: 1.0.2
dependencies:
flutter:
diff --git a/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart b/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart
index 02c7bbb..a5fdbbc 100644
--- a/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart
+++ b/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart
@@ -233,7 +233,7 @@
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
// available on all the versions of Flutter that we test.
// ignore: deprecated_member_use
- defaultBinaryMessenger.handlePlatformMessage(
+ await defaultBinaryMessenger.handlePlatformMessage(
"flutter.io/videoPlayer/videoEvents123",
const StandardMethodCodec()
.encodeSuccessEnvelope(<String, dynamic>{
@@ -248,7 +248,7 @@
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
// available on all the versions of Flutter that we test.
// ignore: deprecated_member_use
- defaultBinaryMessenger.handlePlatformMessage(
+ await defaultBinaryMessenger.handlePlatformMessage(
"flutter.io/videoPlayer/videoEvents123",
const StandardMethodCodec()
.encodeSuccessEnvelope(<String, dynamic>{
@@ -260,7 +260,7 @@
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
// available on all the versions of Flutter that we test.
// ignore: deprecated_member_use
- defaultBinaryMessenger.handlePlatformMessage(
+ await defaultBinaryMessenger.handlePlatformMessage(
"flutter.io/videoPlayer/videoEvents123",
const StandardMethodCodec()
.encodeSuccessEnvelope(<String, dynamic>{
@@ -276,7 +276,7 @@
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
// available on all the versions of Flutter that we test.
// ignore: deprecated_member_use
- defaultBinaryMessenger.handlePlatformMessage(
+ await defaultBinaryMessenger.handlePlatformMessage(
"flutter.io/videoPlayer/videoEvents123",
const StandardMethodCodec()
.encodeSuccessEnvelope(<String, dynamic>{
@@ -288,7 +288,7 @@
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
// available on all the versions of Flutter that we test.
// ignore: deprecated_member_use
- defaultBinaryMessenger.handlePlatformMessage(
+ await defaultBinaryMessenger.handlePlatformMessage(
"flutter.io/videoPlayer/videoEvents123",
const StandardMethodCodec()
.encodeSuccessEnvelope(<String, dynamic>{
