Remove --no-read-only flag Issue #159105 Likely it was added with a misunderstanding of what the flag controls. This flag controls defined here https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/android/avd/avd.py#155 Bug: 159105 Change-Id: Ie25f3699ef7a009b3cf5e092de6bc8f8976e1c82 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/61060 Reviewed-by: Reid Baker <reidbaker@google.com> Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Reid Baker <reidbaker@google.com>
diff --git a/recipe_modules/android_virtual_device/api.py b/recipe_modules/android_virtual_device/api.py index d897c75..8bf4b13 100644 --- a/recipe_modules/android_virtual_device/api.py +++ b/recipe_modules/android_virtual_device/api.py
@@ -148,7 +148,6 @@ 'vpython3', avd_script_path, 'start', - '--no-read-only', '--wipe-data', '--debug-tags', 'all',
diff --git a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json index 42cc02c..ad51281 100644 --- a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json +++ b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_fails.json
@@ -276,7 +276,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -490,7 +489,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -704,7 +702,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json index 78a0be4..a2e3dd8 100644 --- a/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json +++ b/recipe_modules/android_virtual_device/examples/emulator_start_retries.expected/setup_avd_pass_on_retry.json
@@ -276,7 +276,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -490,7 +489,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json b/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json index e4c897b..8d96ef7 100644 --- a/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json +++ b/recipe_modules/android_virtual_device/examples/full.expected/emulator started and stopped, processes killed.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json b/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json index e4c897b..8d96ef7 100644 --- a/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json +++ b/recipe_modules/android_virtual_device/examples/full.expected/emulator started.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json index bf0c162..118e593 100644 --- a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json +++ b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_start_fails.json
@@ -276,7 +276,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -416,7 +415,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -556,7 +554,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json index e4c897b..8d96ef7 100644 --- a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json +++ b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json index e4c897b..8d96ef7 100644 --- a/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json +++ b/recipe_modules/android_virtual_device/examples/full_api_34.expected/emulator_started_and stopped_processes_killed.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json index ddcb759..1c446ed 100644 --- a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json +++ b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started and stopped, processes killed.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json index ddcb759..1c446ed 100644 --- a/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json +++ b/recipe_modules/android_virtual_device/examples/full_legacy_version.expected/emulator started.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json index d39ea62..76ec3a1 100644 --- a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json +++ b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started and stopped, processes killed.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json index d39ea62..76ec3a1 100644 --- a/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json +++ b/recipe_modules/android_virtual_device/examples/full_legacy_version_28.expected/emulator started.json
@@ -273,7 +273,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all", @@ -777,7 +776,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipes/devicelab/devicelab_drone.expected/emulator-test.json b/recipes/devicelab/devicelab_drone.expected/emulator-test.json index 8c63493..f70fd72 100644 --- a/recipes/devicelab/devicelab_drone.expected/emulator-test.json +++ b/recipes/devicelab/devicelab_drone.expected/emulator-test.json
@@ -676,7 +676,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",
diff --git a/recipes/packages/packages.expected/emulator-test.json b/recipes/packages/packages.expected/emulator-test.json index 7066d5e..c789af1 100644 --- a/recipes/packages/packages.expected/emulator-test.json +++ b/recipes/packages/packages.expected/emulator-test.json
@@ -832,7 +832,6 @@ "vpython3", "[CACHE]/avd/src/tools/android/avd/avd.py", "start", - "--no-read-only", "--wipe-data", "--debug-tags", "all",