roll goldctl to 693440007b584af29f4e6a5c0f08c2d17634cc77
Change-Id: I0fc9340fb7feb86e1d777463d9d52caae78dbd85
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/38126
Reviewed-by: Mouad Debbar <mdebbar@google.com>
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
Commit-Queue: Yegor Jbanov <yjbanov@google.com>
Reviewed-by: Christopher Fujino <fujino@google.com>
diff --git a/recipe_modules/flutter_deps/api.py b/recipe_modules/flutter_deps/api.py
index 570cbfa..8d7aca9 100644
--- a/recipe_modules/flutter_deps/api.py
+++ b/recipe_modules/flutter_deps/api.py
@@ -127,12 +127,25 @@
def goldctl(self, env, env_prefixes, version):
"""Downloads goldctl from CIPD and updates the environment variables.
+ To roll to a new version of goldctl visit this page:
+
+ https://chrome-infra-packages.appspot.com/p/skia/tools/goldctl
+
+ Select linux-amd64 and click on a package marked "latest". In the "Tags"
+ section find the freshest tag prefixed with `git_revision`. Copy the value
+ of the tag including "git_revision:" and the SHA following it, for example:
+
+ git_revision:somelongshacontainingnumbersandletters12
+
+ Then replace the default value of `version` variable in this function with
+ it.
+
Args:
env(dict): Current environment variables.
env_prefixes(dict): Current environment prefixes variables.
version(str): The goldctl version to install.
"""
- version = version or 'git_revision:d38e22e2bde5edd79b4137583097e6ef59dee329'
+ version = version or 'git_revision:693440007b584af29f4e6a5c0f08c2d17634cc77'
with self.m.step.nest('Download goldctl'):
goldctl_cache_dir = self.m.path['cache'].join('gold')
self.m.cipd.ensure(
diff --git a/recipes/engine/web_engine_drone.expected/basic.json b/recipes/engine/web_engine_drone.expected/basic.json
index 3bebbc9..70d4e9d 100644
--- a/recipes/engine/web_engine_drone.expected/basic.json
+++ b/recipes/engine/web_engine_drone.expected/basic.json
@@ -355,7 +355,7 @@
"-root",
"[CACHE]/gold",
"-ensure-file",
- "skia/tools/goldctl/${platform} git_revision:d38e22e2bde5edd79b4137583097e6ef59dee329",
+ "skia/tools/goldctl/${platform} git_revision:693440007b584af29f4e6a5c0f08c2d17634cc77",
"-max-threads",
"0",
"-json-output",
@@ -368,7 +368,7 @@
"@@@STEP_LOG_LINE@json.output@ \"result\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"\": [@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
- "@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"resolved-instance_id-of-git_revision:d38\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"resolved-instance_id-of-git_revision:693\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"package\": \"skia/tools/goldctl/resolved-platform\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ ]@@@",
