commit 4f4f006a04b6dd38abf58aa441f751f16aaba349
author Mirko Bonadei <mbonadei@chromium.org> Mon Feb 21 09:59:53 2022 +0000
committer Copybara-Service <copybara-worker@google.com> Mon Feb 21 02:09:54 2022 -0800
tree 350876fbeae3c2f013c72c96df32900d9243d2bf
parent ad002f605161c2956086eee3e0dbe609c1534f10

Re-enable hash_test.

This test should now compile correctly after
https://reviews.llvm.org/D118744.

Bug: 1291484
Change-Id: I580188ba87e6e52d62550ba0a5926760a21a3e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472777
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973463}
NOKEYCHECK=True
GitOrigin-RevId: e16379c80f69fc18fc57742e1940667d6bfae5b0

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 63a72af..ebe250f 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -189,8 +189,7 @@
         "absl/container:node_slot_policy_test",
         "absl/container:sample_element_size_test",
         "absl/hash:low_level_hash_test",
-        # TODO(crbug.com/1291484): Re-enable when fixed.
-        # "absl/hash:hash_test",
+        "absl/hash:hash_test",
         "absl/memory:memory_test",
         "absl/meta:type_traits_test",
         "absl/profiling:exponential_biased_test",

absl/hash/BUILD.gn

diff --git a/absl/hash/BUILD.gn b/absl/hash/BUILD.gn
index b2230a7..d05a270 100644
--- a/absl/hash/BUILD.gn
+++ b/absl/hash/BUILD.gn
@@ -40,27 +40,26 @@
   ]
 }
 
-# TODO(crbug.com/1291484): Re-enable when fixed.
-# absl_source_set("hash_test") {
-#   testonly = true
-#   sources = [ "hash_test.cc" ]
-#   deps = [
-#     ":hash",
-#     ":hash_testing",
-#     ":spy_hash_state",
-#     "//third_party/abseil-cpp/absl/base:core_headers",
-#     "//third_party/abseil-cpp/absl/container:btree",
-#     "//third_party/abseil-cpp/absl/container:flat_hash_map",
-#     "//third_party/abseil-cpp/absl/container:flat_hash_set",
-#     "//third_party/abseil-cpp/absl/container:node_hash_map",
-#     "//third_party/abseil-cpp/absl/container:node_hash_set",
-#     "//third_party/abseil-cpp/absl/meta:type_traits",
-#     "//third_party/abseil-cpp/absl/numeric:int128",
-#     "//third_party/abseil-cpp/absl/strings:cord_test_helpers",
-#     "//third_party/googletest:gtest",
-#     "//third_party/googletest:gmock",
-#   ]
-# }
+absl_source_set("hash_test") {
+  testonly = true
+  sources = [ "hash_test.cc" ]
+  deps = [
+    ":hash",
+    ":hash_testing",
+    ":spy_hash_state",
+    "//third_party/abseil-cpp/absl/base:core_headers",
+    "//third_party/abseil-cpp/absl/container:btree",
+    "//third_party/abseil-cpp/absl/container:flat_hash_map",
+    "//third_party/abseil-cpp/absl/container:flat_hash_set",
+    "//third_party/abseil-cpp/absl/container:node_hash_map",
+    "//third_party/abseil-cpp/absl/container:node_hash_set",
+    "//third_party/abseil-cpp/absl/meta:type_traits",
+    "//third_party/abseil-cpp/absl/numeric:int128",
+    "//third_party/abseil-cpp/absl/strings:cord_test_helpers",
+    "//third_party/googletest:gtest",
+    "//third_party/googletest:gmock",
+  ]
+}
 
 absl_source_set("spy_hash_state") {
   testonly = true