[HB] Add note about auditing sanitize code for overflows
diff --git a/src/TODO b/src/TODO index d2b067d..54560aa 100644 --- a/src/TODO +++ b/src/TODO
@@ -3,3 +3,4 @@ - cmap14 support in get_glyph callback - size_t? - Figure out compiler selection (add test for link to libstdc++) +- Audit sanitize for int overflows
diff --git a/src/hb-ot-layout-gpos-private.hh b/src/hb-ot-layout-gpos-private.hh index e357b01..6b20716 100644 --- a/src/hb-ot-layout-gpos-private.hh +++ b/src/hb-ot-layout-gpos-private.hh
@@ -565,7 +565,7 @@ SANITIZE_THIS2 (classDef1, classDef2) && SANITIZE_MEM (values, (valueFormat1.get_size () + valueFormat2.get_size ()) * - class1Count * class2Count); + class1Count * class2Count); /* XXX overflow (in other places too) */ } private: