commit a57ef8df7ebf70f08065233f3ad218c451eff98a
author Garret Rieger <grieger@google.com> Wed Sep 08 17:31:39 2021 -0700
committer Garret Rieger <grieger@google.com> Wed Sep 22 18:18:50 2021 -0600
tree 6d20446f54f9436f1a41e02f45205f4a63a28041
parent 58facaade1c85906fec70584abfe13995a9dd07b

[repacker] default space to 0.

Since vector push() init's new objects to all zeros.

src/hb-repacker.hh

diff --git a/src/hb-repacker.hh b/src/hb-repacker.hh
index 4523601..d207893 100644
--- a/src/hb-repacker.hh
+++ b/src/hb-repacker.hh
@@ -40,7 +40,7 @@
   {
     vertex_t () :
         distance (0),
-        space (1),
+        space (0),
         incoming_edges (0),
         start (0),
         end (0),
@@ -338,7 +338,7 @@
     bool made_changes = false;
     hb_set_t target_links;
     unsigned root_index = root_idx ();
-    int64_t next_space = 1;
+    int64_t next_space = 0;
     for (unsigned i = 0; i <= root_index; i++)
     {
       if (i == root_index && root_idx () > i)
@@ -441,6 +441,7 @@
     clone->obj.head = buffer->head;
     clone->obj.tail = buffer->tail;
     clone->distance = child.distance;
+    clone->space = child.space;
 
     for (const auto& l : child.obj.links)
       clone->obj.links.push (l);
@@ -642,8 +643,8 @@
         if (visited.has (link.objidx)) continue;
 
         const auto& child = vertices_[link.objidx].obj;
-        int64_t child_weight = child.tail - child.head +
-                               ((int64_t) 1 << (link.width * 8)) * vertices_[link.objidx].space;
+        int64_t child_weight = (child.tail - child.head) +
+                               ((int64_t) 1 << (link.width * 8)) * (vertices_[link.objidx].space + 1);
         int64_t child_distance = next_distance + child_weight;
 
         if (child_distance < vertices_[link.objidx].distance)
@@ -874,7 +875,6 @@
 
   sorted_graph.sort_shortest_distance ();
 
-
   if ((table_tag == HB_OT_TAG_GPOS
        ||  table_tag == HB_OT_TAG_GSUB)
       && sorted_graph.will_overflow ())