commit fda200658e3d3e2db466c9eb81be349df94c6704
author Garret Rieger <grieger@google.com> Thu Feb 02 22:03:36 2023 +0000
committer Behdad Esfahbod <behdad@behdad.org> Thu Feb 02 15:25:37 2023 -0700
tree 4b46b27af2880923cea8611cbe2c9be9fbd86c99
parent 9bd3259335322338e2181935dc031fb9d7805e10

[subset] fix missing compiled glyph cleanup when serialization succeeds.

src/OT/glyf/glyf.hh

diff --git a/src/OT/glyf/glyf.hh b/src/OT/glyf/glyf.hh
index d3e6ed4..29328c7 100644
--- a/src/OT/glyf/glyf.hh
+++ b/src/OT/glyf/glyf.hh
@@ -110,12 +110,11 @@
         padded_offsets[i] = glyphs[i].length ();
     }
 
-    if (!glyf_prime->serialize (c->serializer, glyphs.writer (), use_short_loca, c->plan))
-    {
-      if (c->plan->normalized_coords && !c->plan->pinned_at_default)
-          _free_compiled_subset_glyphs (glyphs, glyphs.length - 1);
-      return false;
-    }
+    bool result = glyf_prime->serialize (c->serializer, glyphs.writer (), use_short_loca, c->plan);
+    if (c->plan->normalized_coords && !c->plan->pinned_at_default)
+      _free_compiled_subset_glyphs (glyphs, glyphs.length - 1);
+
+    if (!result) return false;
 
     if (unlikely (c->serializer->in_error ())) return_trace (false);