commit cd21ad339ba41df505924046e9ec20fe2e892173
author Gabe Giosia <gabe@ghearing.com> Tue May 07 00:26:55 2019 -0700
committer Shazron Abdullah <shazron@gmail.com> Tue May 07 15:26:55 2019 +0800
tree 7ef57076d03a62cde0669f46d8f7b2a4257ea777
parent a15979f133ac373ebccc7da3a403f5699fe7e39e

Remove odd memory copy function (#380)

This seems to have been copied from https://stackoverflow.com/questions/9166291/converting-a-cfstringref-to-char

src/ios-deploy/ios-deploy.m

diff --git a/src/ios-deploy/ios-deploy.m b/src/ios-deploy/ios-deploy.m
index f06b01a..7422847 100644
--- a/src/ios-deploy/ios-deploy.m
+++ b/src/ios-deploy/ios-deploy.m
@@ -314,23 +314,6 @@
     return res;
 }
 
-char * MYCFStringCopyUTF8String(CFStringRef aString) {
-  if (aString == NULL) {
-    return NULL;
-  }
-
-  CFIndex length = CFStringGetLength(aString);
-  CFIndex maxSize =
-  CFStringGetMaximumSizeForEncoding(length,
-                                    kCFStringEncodingUTF8);
-  char *buffer = (char *)malloc(maxSize);
-  if (CFStringGetCString(aString, buffer, maxSize,
-                         kCFStringEncodingUTF8)) {
-    return buffer;
-  }
-  return NULL;
-}
-
 CFStringRef get_device_full_name(const AMDeviceRef device) {
     CFStringRef full_name = NULL,
                 device_udid = AMDeviceCopyDeviceIdentifier(device),
@@ -1540,7 +1523,8 @@
             return;
         }
     } else {
-        device_id = MYCFStringCopyUTF8String(found_device_id);
+        // Use the first device we find if a device_id wasn't specified.
+        device_id = strdup(CFStringGetCStringPtr(found_device_id, kCFStringEncodingUTF8));
         found_device = true;
     }