[demangler] Improve buffer hysteresis
Improve demangler buffer hysteresis. If we needed more than double
the buffer, the original code would allocate exactly the amount
needed, and thus consequently the next request would also realloc.
We're very unlikely to get into wanting more than double, after the
first allocation, as it would require the user to have used an
identifier larger than the hysteresis. With machine generated code
that's possible, but unlikely.
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D119972
GitOrigin-RevId: 024495e62660a51edd060b57a95ca68d584d3b43
diff --git a/src/demangle/Utility.h b/src/demangle/Utility.h
index f8190b8..0cf70bd 100644
--- a/src/demangle/Utility.h
+++ b/src/demangle/Utility.h
@@ -37,10 +37,10 @@
void grow(size_t N) {
size_t Need = N + CurrentPosition;
if (Need > BufferCapacity) {
- // Avoid many reallocations during startup, with a bit of hysteresis.
- constexpr size_t MinInitAlloc = 1024;
- if (Need < MinInitAlloc)
- Need = MinInitAlloc;
+ // Reduce the number of reallocations, with a bit of hysteresis. The
+ // number here is chosen so the first allocation will more-than-likely not
+ // allocate more than 1K.
+ Need += 1024 - 32;
BufferCapacity *= 2;
if (BufferCapacity < Need)
BufferCapacity = Need;
