commit cc8d7dfa941fda10d93e6f52db1129c09a8d9799
author Nathan Sidwell <nathan@acm.org> Mon Mar 28 12:38:48 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Mon May 09 05:01:15 2022 -0700
tree 5366921eee525d142fab55e10d3fabfc5c3e9496
parent b2a4b9290986653b6111a11d0b1934aa667ab359

[demangler] Buffer peeking needs buffer

The output buffer has a 'back' member, which returns NUL when you try
it with an empty buffer.  But there are no use cases that need that
additional functionality.  This makes the 'back' member behave more
like STL containers' back members.  (It still returns a value, not a
reference.)

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D123201

GitOrigin-RevId: e48cd7088b736dae5cd572ebb58963c70a4a72b8

src/demangle/Utility.h

diff --git a/src/demangle/Utility.h b/src/demangle/Utility.h
index 6e0fa38..db19dca 100644
--- a/src/demangle/Utility.h
+++ b/src/demangle/Utility.h
@@ -171,7 +171,8 @@
   void setCurrentPosition(size_t NewPos) { CurrentPosition = NewPos; }
 
   char back() const {
-    return CurrentPosition ? Buffer[CurrentPosition - 1] : '\0';
+    assert(CurrentPosition);
+    return Buffer[CurrentPosition - 1];
   }
 
   bool empty() const { return CurrentPosition == 0; }