commit c797c2af6f4e2e8ae93b68f1c41abab1579563db
author Nikias Bassen <nikias@gmx.li> Tue Feb 21 11:05:40 2023 +0100
committer Nikias Bassen <nikias@gmx.li> Tue Feb 21 11:05:40 2023 +0100
tree 8a676b125867be34f2c417b8022afc23e4f8de62
parent 9a5e78fe56267d6c721c92055c3ae9702bd25871

reverse_proxy: Fix use-after-free

src/reverse_proxy.c

diff --git a/src/reverse_proxy.c b/src/reverse_proxy.c
index 3f0a839..3ab1031 100644
--- a/src/reverse_proxy.c
+++ b/src/reverse_proxy.c
@@ -186,10 +186,10 @@
 
 	/* else wait for messages and forward them */
 	int sockfd = socket_connect(host, port);
-	free(host);
 	if (sockfd < 0) {
 		free(buf);
 		_reverse_proxy_log(client, "ERROR: Connection to %s:%u failed: %s", host, port, strerror(errno));
+		free(host);
 		return -1;
 	}
 
@@ -259,6 +259,7 @@
 		}
 	}
 	socket_close(sockfd);
+	free(host);
 	free(buf);
 
 	_reverse_proxy_status(client, RP_STATUS_DISCONNECTED, "Disconnected (out: %u / in: %u)", sent_total, recv_total);