commit 765f062a4563901ecf9881ac541fc248aa30d44d
author Nikias Bassen <nikias@gmx.li> Wed Mar 29 22:08:21 2017 +0200
committer Nikias Bassen <nikias@gmx.li> Wed Mar 29 22:08:21 2017 +0200
tree 01532b7f4049d093a51458fe37a6ac5c6c22b672
parent 012e4a8d7c99baf326cbcf06eabe899e2cdf66f7

xplist: Prevent memory leak(s) when parsing fails

Credit to OSS-Fuzz

src/xplist.c

diff --git a/src/xplist.c b/src/xplist.c
index 022f1cd..f896030 100644
--- a/src/xplist.c
+++ b/src/xplist.c
@@ -1221,7 +1221,7 @@
                         if (!keyname) {
                             PLIST_XML_ERR("missing key name while adding dict item\n");
                             ctx->err++;
-                            break;
+                            goto err_out;
                         }
                         plist_dict_set_item(parent, keyname, subnode);
                         break;
@@ -1232,7 +1232,7 @@
                         /* should not happen */
                         PLIST_XML_ERR("parent is not a structered node\n");
                         ctx->err++;
-                        break;
+                        goto err_out;
                     }
                 }
                 if (!is_empty && (data->type == PLIST_DICT || data->type == PLIST_ARRAY)) {