commit 783777b8e1082a9275d2c6c1aa6b7996e9c4ff00
author Nikias Bassen <nikias@gmx.li> Sat Jan 28 05:20:44 2017 +0100
committer Nikias Bassen <nikias@gmx.li> Sat Jan 28 05:20:44 2017 +0100
tree 9ef81035620cb497a3a2cc49b062e4d8cbbc1f42
parent 30e14a3ec62ddc37738b8afe2345413397410420

bplist: Don't duplicate output buffer in plist_to_bin()

src/bplist.c

diff --git a/src/bplist.c b/src/bplist.c
index 0c57a75..64c9081 100644
--- a/src/bplist.c
+++ b/src/bplist.c
@@ -1154,6 +1154,7 @@
         uint64_t offset = be64toh(offsets[i]);
         byte_array_append(bplist_buff, (uint8_t*)&offset + (sizeof(uint64_t) - offset_size), offset_size);
     }
+    free(offsets);
 
     //setup trailer
     memset(trailer.unused, '\0', sizeof(trailer.unused));
@@ -1165,11 +1166,10 @@
 
     byte_array_append(bplist_buff, &trailer, sizeof(bplist_trailer_t));
 
-    //duplicate buffer
-    *plist_bin = (char *) malloc(bplist_buff->len);
-    memcpy(*plist_bin, bplist_buff->data, bplist_buff->len);
+    //set output buffer and size
+    *plist_bin = bplist_buff->data;
     *length = bplist_buff->len;
 
+    bplist_buff->data = NULL; // make sure we don't free the output buffer
     byte_array_free(bplist_buff);
-    free(offsets);
 }