commit eb929319388cb7f48141b3fde062a8392fe4c00d
author Nikias Bassen <nikias@gmx.li> Tue Feb 07 02:17:55 2017 +0100
committer Nikias Bassen <nikias@gmx.li> Tue Feb 07 02:17:55 2017 +0100
tree 6d546817bd787793533dde98eb4493dd637bcab8
parent cf9ee441ae0ef0dff4f16c3a7f5652ed113ff7bc

plistutil: Print error message when opening input/output file fails and plug memory leaks on error

tools/plistutil.c

diff --git a/tools/plistutil.c b/tools/plistutil.c
index 7652bdc..a1a8c9c 100644
--- a/tools/plistutil.c
+++ b/tools/plistutil.c
@@ -27,6 +27,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
+#include <errno.h>
 
 #ifdef _MSC_VER
 #pragma warning(disable:4996)
@@ -124,14 +125,18 @@
     // read input file
     iplist = fopen(options->in_file, "rb");
     if (!iplist) {
+        printf("ERROR: Could not open input file '%s': %s\n", options->in_file, strerror(errno));
         free(options);
         return 1;
     }
 
-    stat(options->in_file, &filestats);
+    memset(&filestats, '\0', sizeof(struct stat));
+    fstat(fileno(iplist), &filestats);
 
     if (filestats.st_size < 8) {
         printf("ERROR: Input file is too small to contain valid plist data.\n");
+        free(options);
+        fclose(iplist);
         return -1;
     }
 
@@ -159,6 +164,7 @@
         {
             FILE *oplist = fopen(options->out_file, "wb");
             if (!oplist) {
+                printf("ERROR: Could not open output file '%s': %s\n", options->out_file, strerror(errno));
                 free(options);
                 return 1;
             }