commit 3789cba2f2fa0c8674b737887d8fe6172deeaa68
author Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Fri Sep 08 09:34:08 2017 -0500
committer Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Fri Sep 08 09:34:08 2017 -0500
tree b91820b11ef2225efc6c8275c498d48a51d59268
parent 8592873f24bf860007c1b3461fc369e5940361a7

[libpng16] Attempt to isolate an oss-fuzz issue in png_set_text_2

png.c

diff --git a/png.c b/png.c
index d324cd7..866395e 100644
--- a/png.c
+++ b/png.c
@@ -1,7 +1,7 @@
 
 /* png.c - location for general purpose libpng functions
  *
- * Last changed in libpng 1.6.32 [August 24, 2017]
+ * Last changed in libpng 1.6.33 [(PENDING RELEASE)]
  * Copyright (c) 1998-2002,2004,2006-2017 Glenn Randers-Pehrson
  * (Version 0.96 Copyright (c) 1996, 1997 Andreas Dilger)
  * (Version 0.88 Copyright (c) 1995, 1996 Guy Eric Schalnat, Group 42, Inc.)

pngset.c

diff --git a/pngset.c b/pngset.c
index 6f3a1ee..6d44104 100644
--- a/pngset.c
+++ b/pngset.c
@@ -1,7 +1,7 @@
 
 /* pngset.c - storage of image information into info struct
  *
- * Last changed in libpng 1.6.32 [August 24, 2017]
+ * Last changed in libpng 1.6.33 [(PENDING RELEASE)]
  * Copyright (c) 1998-2017 Glenn Randers-Pehrson
  * (Version 0.96 Copyright (c) 1996, 1997 Andreas Dilger)
  * (Version 0.88 Copyright (c) 1995, 1996 Guy Eric Schalnat, Group 42, Inc.)
@@ -837,6 +837,9 @@
       size_t lang_len, lang_key_len;
       png_textp textp = &(info_ptr->text[info_ptr->num_text]);
 
+      int text_is_null=0;
+      int text_0_is_0=0;
+
       if (text_ptr[i].key == NULL)
           continue;
 
@@ -881,7 +884,12 @@
       }
 #  endif
 
-      if (text_ptr[i].text == NULL || text_ptr[i].text[0] == '\0')
+      if (text_ptr[i].text == NULL)
+         text_is_null=1;
+      if (text_ptr[i].text[0] == '\0')
+         text_0_is_0=1;
+
+      if (text_is_null || text_0_is_0)
       {
          text_length = 0;
 #  ifdef PNG_iTXt_SUPPORTED