commit d7edcc40e49d76636ec7a19e0e23359e6d3db9c1
author Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Wed Sep 13 19:34:51 2017 -0500
committer Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Wed Sep 13 19:34:51 2017 -0500
tree bae715a41702a0bcbdb91487a83b2af12bdfbb64
parent 7d40b53fbf9a472cd38a5a498d333b8c76a1d192

[libpng16] Undo failed attempt to debug UMR in png_set_text_2().

pngset.c

diff --git a/pngset.c b/pngset.c
index 7498b67..e622fdd 100644
--- a/pngset.c
+++ b/pngset.c
@@ -837,9 +837,6 @@
       size_t lang_len, lang_key_len;
       png_textp textp = &(info_ptr->text[info_ptr->num_text]);
 
-      int text_is_null=0;
-      int text_0_is_0=0;
-
       if (text_ptr[i].key == NULL)
           continue;
 
@@ -884,13 +881,8 @@
       }
 #  endif
 
-      if (text_ptr[i].text == NULL)
-         text_is_null=1;
-      else if (text_ptr[i].text[0] == '\0') /* FIX THIS */
-         text_0_is_0=1;
-
-      /* oss-fuzz complains of UMR on the reference to text_0_is_0 */
-      if (text_is_null || text_0_is_0)
+      /* oss-fuzz complains of UMR here */
+      if (text_ptr[i].text == NULL || text_ptr[i].text[0] == '\0')
       {
          text_length = 0;
 #  ifdef PNG_iTXt_SUPPORTED