commit 22988d874570c35251076f9edc1cd3c99ecb6785
author Rosen Penev <rosenp@gmail.com> Wed Jun 03 15:50:19 2020 -0700
committer Nikias Bassen <nikias@gmx.li> Wed Dec 30 02:54:57 2020 +0100
tree 725a1119380e8745aa92d1ae53ce627c337410c5
parent e7168f30e6fdf0a1f9cffdc9252f52d45e5a59ef

Add parentheses to macro arguments

[clang-tidy] Found with bugprone-macro-parentheses

Signed-off-by: Rosen Penev <rosenp@gmail.com>

common/collection.c

diff --git a/common/collection.c b/common/collection.c
index 92bd645..8a2fe72 100644
--- a/common/collection.c
+++ b/common/collection.c
@@ -31,7 +31,7 @@
 #undef NDEBUG // we need to make sure we still get assertions because we can't handle memory allocation errors
 #include <assert.h>
 
-#define INIT_NULL(addr, count) { unsigned int i_ = 0; for (i_ = 0; i_ < count; i_++) ((void**)addr)[i_] = NULL; }
+#define INIT_NULL(addr, count) { unsigned int i_ = 0; for (i_ = 0; i_ < (count); i_++) ((void**)(addr))[i_] = NULL; }
 
 #define CAPACITY_STEP 8
 

tools/iproxy.c

diff --git a/tools/iproxy.c b/tools/iproxy.c
index 5dca580..bd56ebd 100644
--- a/tools/iproxy.c
+++ b/tools/iproxy.c
@@ -68,9 +68,9 @@
 };
 
 #define CDATA_FREE(x) if (x) { \
-	if (x->fd > 0) socket_close(x->fd); \
-	if (x->sfd > 0) socket_close(x->sfd); \
-	free(x->udid); \
+	if ((x)->fd > 0) socket_close((x)->fd); \
+	if ((x)->sfd > 0) socket_close((x)->sfd); \
+	free((x)->udid); \
 	free(x); \
 }