commit ddd6fdb41ef319016214fc97566eee3cf993aeb8
author Force Charlie <charlieio@outlook.com> Tue Jul 14 20:56:01 2020 +0800
committer Force Charlie <charlieio@outlook.com> Tue Jul 14 20:56:01 2020 +0800
tree 19ca81fa231d7e9e9f8dba0b7d16eed0627e6ae1
parent e8f26d64cf3bc53da36275bfd27413fe128c2fc6

Cleanup zstd support

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 881bb79..f418461 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -206,13 +206,11 @@
 
 if(ENABLE_ZSTD)
   find_package(LibZSTD)
-  if(ZSTD_FOUND)
+  if(LIBZSTD_FOUND)
     set(HAVE_LIBZSTD 1)
-    include_directories(${ZSTD_INCLUDE_DIR})
-    set(OPTIONAL_LIBRARY ${OPTIONAL_LIBRARY} ${ZSTD_LIBRARY})
   else()
     message(WARNING "-- zstd library not found; zstd support disabled")
-  endif(ZSTD_FOUND)
+  endif(LIBZSTD_FOUND)
 endif(ENABLE_ZSTD)
 
 if (COMMONCRYPTO_FOUND)
@@ -310,7 +308,6 @@
 endforeach()
 string(REGEX REPLACE "-lBZip2::BZip2" "-lbz2" LIBS ${LIBS})
 string(REGEX REPLACE "-lLibLZMA::LibLZMA" "-llzma" LIBS ${LIBS})
-string(REGEX REPLACE "-lLibZSTD::LibZSTD" "-lzstd" LIBS ${LIBS})
 string(REGEX REPLACE "-lOpenSSL::Crypto" "-lssl -lcrypto" LIBS ${LIBS})
 string(REGEX REPLACE "-lZLIB::ZLIB" "-lz" LIBS ${LIBS})
 string(REGEX REPLACE "-lGnuTLS::GnuTLS" "-lgnutls" LIBS ${LIBS})

cmake/FindLibZSTD.cmake

diff --git a/cmake/FindZstd.cmake b/cmake/FindLibZSTD.cmake
similarity index 85%
rename from cmake/FindZstd.cmake
rename to cmake/FindLibZSTD.cmake
index 89300dd..8ae328a 100644
--- a/cmake/FindZstd.cmake
+++ b/cmake/FindLibZSTD.cmake
@@ -29,13 +29,11 @@
 SELECT_LIBRARY_CONFIGURATIONS(ZSTD)
 
 include(FindPackageHandleStandardArgs)
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(
-    ZSTD DEFAULT_MSG
-    ZSTD_LIBRARY ZSTD_INCLUDE_DIR
+find_package_handle_standard_args(LibZSTD
+    FOUND_VAR LIBZSTD_FOUND
+    REQUIRED_VARS 
+      ZSTD_LIBRARY ZSTD_INCLUDE_DIR
+    VERSION_VAR ZSTD_VERSION
 )
 
-if (ZSTD_FOUND)
-    message(STATUS "Found Zstd: ${ZSTD_LIBRARY}")
-endif()
-
 mark_as_advanced(ZSTD_INCLUDE_DIR ZSTD_LIBRARY)

lib/CMakeLists.txt

diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt
index d51ce1c..d631e42 100644
--- a/lib/CMakeLists.txt
+++ b/lib/CMakeLists.txt
@@ -148,7 +148,7 @@
 
 if(HAVE_LIBZSTD)
   target_sources(zip PRIVATE zip_algorithm_zstd.c)
-  target_link_libraries(zip PRIVATE LibZSTD::LibZSTD)
+  target_link_libraries(zip PRIVATE zstd)
 endif()
 
 if(HAVE_COMMONCRYPTO)