Dead code removal from apps Some miscellaneous removal of dead code from apps. Also fix an issue with error handling with pkcs7. Reviewed-by: Richard Levitte <levitte@openssl.org>
diff --git a/apps/pkcs7.c b/apps/pkcs7.c index 4d80f82..643507f 100644 --- a/apps/pkcs7.c +++ b/apps/pkcs7.c
@@ -189,11 +189,11 @@ if (infile == NULL) BIO_set_fp(in, stdin, BIO_NOCLOSE); else { - if (BIO_read_filename(in, infile) <= 0) - if (in == NULL) { - perror(infile); - goto end; - } + if (BIO_read_filename(in, infile) <= 0) { + BIO_printf(bio_err, "unable to load input file\n"); + ERR_print_errors(bio_err); + goto end; + } } if (informat == FORMAT_ASN1)
diff --git a/apps/s_server.c b/apps/s_server.c index 874b402..ec2fe6f 100644 --- a/apps/s_server.c +++ b/apps/s_server.c
@@ -303,7 +303,7 @@ } if (s_debug) BIO_printf(bio_s_out, "identity_len=%d identity=%s\n", - identity ? (int)strlen(identity) : 0, identity); + (int)strlen(identity), identity); /* here we could lookup the given identity e.g. from a database */ if (strcmp(identity, psk_identity) != 0) {