Remove repeated condition from if in X509_NAME_oneline An if checks the value of |type| to see if it is V_ASN1_VISIBLESTRING twice. We only need to do it once. GitHub Issue #656 Reviewed-by: Richard Levitte <levitte@openssl.org>
diff --git a/crypto/x509/x509_obj.c b/crypto/x509/x509_obj.c index eaa03f2..1297307 100644 --- a/crypto/x509/x509_obj.c +++ b/crypto/x509/x509_obj.c
@@ -129,7 +129,7 @@ type == V_ASN1_VISIBLESTRING || type == V_ASN1_PRINTABLESTRING || type == V_ASN1_TELETEXSTRING || - type == V_ASN1_VISIBLESTRING || type == V_ASN1_IA5STRING) { + type == V_ASN1_IA5STRING) { if (num > (int)sizeof(ebcdic_buf)) num = sizeof(ebcdic_buf); ascii2ebcdic(ebcdic_buf, q, num);