commit 66cb4fcdc5039fe5b1476ed48a936137a307a58b
author Pauli <pauli@openssl.org> Fri Apr 01 12:18:44 2022 +1100
committer Pauli <pauli@openssl.org> Fri May 06 18:21:22 2022 +1000
tree 36f0a10a7987501dfa6212f3f60b57f54389a9b1
parent 588080cbf8e254ca2c033224146bc29fddea75a7

Fix Coverity 1503329 use after free

Another false positive tagged as such

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/18014)

crypto/store/store_lib.c

diff --git a/crypto/store/store_lib.c b/crypto/store/store_lib.c
index 696056e..3d91f15 100644
--- a/crypto/store/store_lib.c
+++ b/crypto/store/store_lib.c
@@ -215,6 +215,8 @@
          */
         (void)ossl_store_close_it(&tmpctx);
     }
+    /* Coverity false positive, the reference counting is confusing it */
+    /* coverity[pass_freed_arg] */
     OSSL_STORE_LOADER_free(fetched_loader);
     OPENSSL_free(propq_copy);
     OPENSSL_free(ctx);