[Impeller] Fix 1-d grid computation for compute (#42516)

Note that the 2d grid case is still incorrect. Consider: the grid size should be the number of compute units required, but the threadgroup size is a minimum number of compute units.

If I need to process a 50x50 image, I should be able to set a grid size of 50x50. Since the minimum threadgroup size is probably bigger (say 1024), this should turn into one dispatch of size (1, 1, 1). However with the current implementation, we will make a dispatch of (50, 50, 1), which essentially squares the amount of work - doing one thread group per unit of compute.

The correct implementation for 2d compute should take the mod of each grid dimension with the threadgroup size in that dimension. I did not fix this case as we do not have a use for 2d compute yet.
12 files changed
tree: 75d345235ffbd968134f8a25f08b492e39d4c1d5
  1. .github/
  2. assets/
  3. benchmarking/
  4. build/
  5. ci/
  6. common/
  7. display_list/
  8. docs/
  9. examples/
  10. flow/
  11. flutter_frontend_server/
  12. flutter_vma/
  13. fml/
  14. impeller/
  15. lib/
  16. runtime/
  17. shell/
  18. sky/
  19. testing/
  20. third_party/
  21. tools/
  22. vulkan/
  23. wasm/
  24. web_sdk/
  25. .ci.yaml
  26. .clang-format
  27. .clang-tidy
  28. .gitattributes
  29. .gitignore
  30. .pylintrc
  31. .style.yapf
  32. analysis_options.yaml
  33. AUTHORS
  34. BUILD.gn
  35. CODEOWNERS
  36. CONTRIBUTING.md
  37. DEPS
  38. Doxyfile
  39. LICENSE
  40. README.md
README.md

Flutter Engine

OpenSSF Scorecard

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.

If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.

If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.

Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.