| commit | 59916a9bceb673104da3767d76a5d0414c95a5f1 | [log] [tgz] |
|---|---|---|
| author | stuartmorgan <stuartmorgan@google.com> | Wed Apr 24 14:30:05 2024 -0400 |
| committer | GitHub <noreply@github.com> | Wed Apr 24 18:30:05 2024 +0000 |
| tree | ef9ed3434e790801f1d9077e0a6dfb84c675fb93 | |
| parent | 890ec3609649a1d581895d0f2cd4c7bc2a1885bf [diff] |
[camera] Finish converting iOS to Pigeon (#6601) Converts all remaining Dart->host communication in the iOS implementation to use Pigeon. Given the boilerplate nature of many of the changes, it seemed easiest to just do the remaining calls all at once now that the structure is in place. Some high-level notes: - Many methods used to send the `cameraId` without it ever being used on the native side, so the Pigeon versions do not send them. - `ThreadSafeTextureRegistry` is removed because I discovered that it was masking a bug, so was more trouble than it was worth (see inline comments in PR). - A number of enums have been removed in favor of using the Pigeon-generated enums to pass data from the plugin class to `FLTCam`. - In many cases where the completion callback (previously `result`) was being passed to `FLTCam` in a call, only to have it always just call `result(nil)`, that's now done in the plugin class since it's easier to reason about completions being called when they aren't passed around. (Long term we should consider moving almost all of the rest out, and using `FlutterError*` out params that the plugin class passes to `completion`, but that is more surgery than I wanted to do in this PR.) Completes the iOS portion of https://github.com/flutter/flutter/issues/117905
This repo is a companion repo to the main flutter repo. It contains the source code for Flutter's first-party packages (i.e., packages developed by the core Flutter team). Check the packages directory to see all packages.
These packages are also available on pub.
Please file any issues, bugs, or feature requests in the main flutter repo. Issues pertaining to this repository are labeled “package”.
If you wish to contribute a new package to the Flutter ecosystem, please see the documentation for developing packages. You can store your package source code in any GitHub repository (the present repo is only intended for packages developed by the core Flutter team). Once your package is ready you can publish to the pub repository.
If you wish to contribute a change to any of the existing packages in this repo, please review our contribution guide, and send a pull request.
These are the packages hosted in this repository:
