blob: 08c607aad2a4e0a29b8dfab8fe5989d0be8aafdc [file] [log] [blame]
Benjamin Kaduke4d94262016-09-26 15:30:42 -05001HOW TO CONTRIBUTE PATCHES TO OpenSSL
Rich Salzf2b9c252016-04-26 15:50:28 -04002------------------------------------
Manish Goregaokareb05f172015-10-17 16:40:55 +05303
Matt Caswell75737d42016-06-02 11:03:10 +01004(Please visit https://www.openssl.org/community/getting-started.html for
Rich Salzf2b9c252016-04-26 15:50:28 -04005other ideas about how to contribute.)
Manish Goregaokareb05f172015-10-17 16:40:55 +05306
Rich Salzf2b9c252016-04-26 15:50:28 -04007Development is coordinated on the openssl-dev mailing list (see the
Matt Caswell75737d42016-06-02 11:03:10 +01008above link or https://mta.openssl.org for information on subscribing).
Manish Goregaokareb05f172015-10-17 16:40:55 +05309If you are unsure as to whether a feature will be useful for the general
Rich Salzf2b9c252016-04-26 15:50:28 -040010OpenSSL community you might want to discuss it on the openssl-dev mailing
11list first. Someone may be already working on the same thing or there
12may be a good reason as to why that feature isn't implemented.
Manish Goregaokareb05f172015-10-17 16:40:55 +053013
Rich Salz7954dce2016-10-12 15:49:06 -040014To submit a patch, make a pull request on GitHub. If you think the patch
15could use feedback from the community, please start a thread on openssl-dev
16to discuss it.
Manish Goregaokareb05f172015-10-17 16:40:55 +053017
Rich Salz7954dce2016-10-12 15:49:06 -040018Having addressed the following items before the PR will help make the
19acceptance and review process faster:
Rich Salzf2b9c252016-04-26 15:50:28 -040020
21 1. Anything other than trivial contributions will require a contributor
22 licensing agreement, giving us permission to use your code. See
Matt Caswell75737d42016-06-02 11:03:10 +010023 https://www.openssl.org/policies/cla.html for details.
Rich Salzf2b9c252016-04-26 15:50:28 -040024
25 2. All source files should start with the following text (with
26 appropriate comment characters at the start of each line and the
27 year(s) updated):
28
29 Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved.
30
31 Licensed under the OpenSSL license (the "License"). You may not use
32 this file except in compliance with the License. You can obtain a copy
33 in the file LICENSE in the source distribution or at
34 https://www.openssl.org/source/license.html
35
Rich Salz7954dce2016-10-12 15:49:06 -040036 3. Patches should be as current as possible; expect to have to rebase
37 often. We do not accept merge commits; You will be asked to remove
38 them before a patch is considered acceptable.
Rich Salzf2b9c252016-04-26 15:50:28 -040039
Matt Caswell75737d42016-06-02 11:03:10 +010040 4. Patches should follow our coding style (see
Rich Salzf2b9c252016-04-26 15:50:28 -040041 https://www.openssl.org/policies/codingstyle.html) and compile without
FdaSilvaYYf430ba32016-06-19 19:39:01 +020042 warnings. Where gcc or clang is available you should use the
Matt Caswell75737d42016-06-02 11:03:10 +010043 --strict-warnings Configure option. OpenSSL compiles on many varied
44 platforms: try to ensure you only use portable features.
Rich Salz7954dce2016-10-12 15:49:06 -040045 Clean builds via Travis and AppVeyor are expected, and done whenever
46 a PR is created or updated.
Rich Salzf2b9c252016-04-26 15:50:28 -040047
Rich Salz7954dce2016-10-12 15:49:06 -040048 5. When at all possible, patches should include tests. These can
49 either be added to an existing test, or completely new. Please see
50 test/README for information on the test framework.
Matt Caswell49c2a002016-06-03 10:51:13 +010051
Rich Salz7954dce2016-10-12 15:49:06 -040052 6. New features or changed functionality must include
Beat Bolli663ece02016-11-18 10:17:28 +010053 documentation. Please look at the "pod" files in doc/man[1357]
54 for examples of our style.